-
Notifications
You must be signed in to change notification settings - Fork 18
refactor!: switch from multipart to multer to resolve deprecation warnings and dependabot alerts #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 70.91% 70.97% +0.05%
==========================================
Files 423 423
Lines 61780 61800 +20
==========================================
+ Hits 43810 43861 +51
+ Misses 17970 17939 -31
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-02-11 15:32:34 Comparing candidate commit 9880d79 in PR branch Found 20 performance improvements and 8 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:benching serializing traces from their internal representation to msgpack
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/bad-name
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:normalization/normalize_service/normalize_service/[empty string]
scenario:redis/obfuscate_redis_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
33d11fb to
3fdb3e4
Compare
3fdb3e4 to
31529c3
Compare
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
31529c3 to
4537bdd
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
libdd-common/src/test_utils.rs
Outdated
| let mut parts = Vec::new(); | ||
| // multer is async, which is unnecessary for our use-case so just wrap in block_on to maintain a | ||
| // sync API | ||
| futures::executor::block_on(parse_multipart_async(boundary, body.to_vec())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any risk if this is run as part of a tokio test?
4537bdd to
9880d79
Compare
What does this PR do?
When compiling libdatadog we get the warning:
warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, multipart v0.18.0, typemap v0.3.3. Additionally, we're seeing the following dependabot warnings:https://github.com/DataDog/libdatadog/security/dependabot/34
https://github.com/DataDog/libdatadog/security/dependabot/33
https://github.com/DataDog/libdatadog/security/dependabot/32
We only use
multipartin tests. This PR switches to using multer.Motivation
What inspired you to submit this pull request?
Additional Notes
This isn't actually a breaking change. Dependencies are changing and internal implementation of test-only functionality is changing.
How to test the change?
Describe here in detail how the change can be validated.