fix(logs): use UnixMilli for v1 logs search timestamps#15
Closed
ibrahimridene wants to merge 1 commit into
Closed
Conversation
parseTimeString returns milliseconds but runLogsSearch passed them to time.Unix which expects seconds, producing timestamps far in the future and causing 400 Bad Request from the API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📊 Test Coverage ReportThreshold: 80% ❌ Coverage by Package📈 Coverage Status: ❌ FAILED - Coverage below minimum threshold Updated for commit 0dda97c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseTimeStringreturns milliseconds butrunLogsSearchpassed them totime.Unix()which expects seconds400 Bad Requestfrom the Datadog APItime.UnixMilli()instead oftime.Unix()Test plan
pup logs search --query="status:error" --from="1h"and verify it returns results instead of 400pup logs search --query="*" --from="30m" --limit=5to confirm basic queries work🤖 Generated with Claude Code