fix(test): prevent panic on missing API/App key#21
Closed
giannileggio wants to merge 1 commit into
Closed
Conversation
The test command panicked with slice bounds out of range when DD_APP_KEY (or DD_API_KEY) was not set, because it tried to mask an empty string. Add explicit checks before the masking code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
fixed in #20 |
Author
closing this |
📊 Test Coverage ReportThreshold: 80% ✅ Coverage by Package📈 Coverage Status: ✅ PASSED - Coverage meets minimum threshold Updated for commit 8d510b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pup testpanicked withslice bounds out of range [:8] with length 0whenDD_APP_KEY(orDD_API_KEY) was not set, because the masking code tried to slice an empty stringChanges
cmd/root.go:208-214- validateAPIKeyandAppKeyare non-empty before slicingcmd/root_test.go- addedTestTestCmd_MissingKeys(3 cases) andTestTestCmd_ValidKeysTesting
go test ./...all passingpup testwith missing app key now returns a helpful error instead of panicking