Skip to content

fix(cmd): remove deprecated findings endpoints and broken vulnerabilities commands#24

Merged
platinummonkey merged 1 commit into
mainfrom
etienne.leblan/security-api-fixes
Feb 10, 2026
Merged

fix(cmd): remove deprecated findings endpoints and broken vulnerabilities commands#24
platinummonkey merged 1 commit into
mainfrom
etienne.leblan/security-api-fixes

Conversation

@etienneddog
Copy link
Copy Markdown

Summary

Remove deprecated and broken security/vulnerability commands:

  • security findings list and security findings get — API endpoints being deprecated by Datadog
  • vulnerabilities search and vulnerabilities list — using wrong API methods (signals API instead of vulnerabilities API)

Changes

  • Remove security findings list and security findings get commands, handlers, and flags from cmd/security.go
  • Remove vulnerabilities top-level command entirely (both subcommands removed) from cmd/vulnerabilities.go and cmd/root.go
  • Update tests in cmd/security_test.go and cmd/vulnerabilities_test.go
  • security findings search and all static-analysis commands remain intact

Testing

  • go build ./... passes
  • go test ./cmd/... passes
  • go vet ./cmd/... passes

Related Issues

N/A


🤖 Generated with Claude Code

…ties commands

Remove security findings list/get commands (API endpoints being deprecated)
and vulnerabilities search/list commands (using wrong API methods - signals
instead of vulnerabilities). Security findings search and all static-analysis
commands remain intact.

- Remove `security findings list` and `security findings get`
- Remove `vulnerabilities search` and `vulnerabilities list`
- Unregister `vulnerabilities` command from root
- Update tests accordingly

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@etienneddog etienneddog requested a review from a team as a code owner February 10, 2026 17:57
@github-actions
Copy link
Copy Markdown

📊 Test Coverage Report

Overall Coverage: 80.4% Coverage

Threshold: 80% ✅

Coverage by Package
## Coverage by Package

- github.com/DataDog/pup/pkg/auth/callback/server.go:40: 81.2%
- github.com/DataDog/pup/pkg/auth/dcr/client.go:28: 100.0%
- github.com/DataDog/pup/pkg/auth/dcr/types.go:24: 100.0%
- github.com/DataDog/pup/pkg/auth/oauth/client.go:22: 100.0%
- github.com/DataDog/pup/pkg/auth/oauth/pkce.go:24: 85.7%
- github.com/DataDog/pup/pkg/auth/storage/factory.go:53: 94.7%
- github.com/DataDog/pup/pkg/auth/storage/keychain.go:44: 42.9%
- github.com/DataDog/pup/pkg/auth/storage/storage.go:58: 71.4%
- github.com/DataDog/pup/pkg/auth/types/types.go:23: 100.0%
- github.com/DataDog/pup/pkg/client/client.go:32: 94.4%
- github.com/DataDog/pup/pkg/config/config.go:22: 100.0%
- github.com/DataDog/pup/pkg/formatter/formatter.go:31: 100.0%
- github.com/DataDog/pup/pkg/useragent/useragent.go:32: 100.0%
- github.com/DataDog/pup/pkg/util/time.go:20: 95.8%

## Summary

total:								(statements)		80.4%

📈 Coverage Status: ✅ PASSED - Coverage meets minimum threshold

Updated for commit d0004e6

@platinummonkey platinummonkey merged commit 9c0522a into main Feb 10, 2026
4 checks passed
@platinummonkey platinummonkey deleted the etienne.leblan/security-api-fixes branch February 10, 2026 18:02
etienneddog pushed a commit that referenced this pull request Feb 10, 2026
Update README, COMMANDS.md, EXAMPLES.md, and TEST_COVERAGE_SUMMARY.md
to reflect the removal of security findings list/get and vulnerabilities
search/list commands in PR #24.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants