feat(security): improve findings UX for agents and humans#343
Merged
platinummonkey merged 4 commits intoApr 10, 2026
Merged
Conversation
- Add signals vs findings conceptual model to security --help - Group subcommands: Query & Investigate vs Configure - Add common fields reference to findings analyze help - Document filter vs WHERE query boundary - Add 5 example queries including finding_types filter - Improve 400 error messages with actionable checklist - Surface long_about in agent-mode JSON schema - Update README: Cloud Security and App Security now covered Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sassierl-dd
approved these changes
Apr 10, 2026
platinummonkey
previously approved these changes
Apr 10, 2026
The fetch endpoint expects "advanced_query_fetch_request" but build_fetch_request was reusing the initial "analysis_workspace_query_request" type, causing 400 errors on async query polling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This reverts commit 773d462.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
platinummonkey
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements UX improvements for
security findingsbased on agent feedback. Makes the security command tree more navigable andfindings analyzemore self-documenting.Changes
security --helpmain.rsmain.rsfindings analyzehelpmain.rsmain.rsfinding_typesfilter)main.rssecurity.rslong_aboutin agent-mode JSON schema (was only showing shortabout)main.rsREADME.mdTesting
cargo test— 730 passcargo clippy -- -D warnings— cleancargo fmt --check— cleancargo run -- security --help— verified COMMANDS grouping and CONCEPTS visible in JSONcargo run -- security findings analyze --help— verified common fields, filter vs WHERE, all examples visible in JSON🤖 Generated with Claude Code