Fix: Validate join columns before join execution (#118)#159
Open
manavgupta26 wants to merge 1 commit intoDataHaskell:mainfrom
Open
Fix: Validate join columns before join execution (#118)#159manavgupta26 wants to merge 1 commit intoDataHaskell:mainfrom
manavgupta26 wants to merge 1 commit intoDataHaskell:mainfrom
Conversation
…ed cartesian product (DataHaskell#118)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #118
Previously, when a non-existent column was passed to join functions (e.g. rightJoin ["Cats"]), the code would silently proceed and perform a cartesian product due to empty join keys.
This happened because no validation was performed before computing row hashes.
Changes:
validateJoinColumnshelper functionNow the join functions throw an error if any specified column does not exist in either dataframe.