Conversation
|
@SlimDeluxe EC-207 |
SlimDeluxe
left a comment
There was a problem hiding this comment.
Need some changes after improving the column in the common package.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
============================================
- Coverage 32.63% 32.30% -0.33%
+ Complexity 1232 1227 -5
============================================
Files 96 96
Lines 5951 5943 -8
============================================
- Hits 1942 1920 -22
- Misses 4009 4023 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Will wait for DataLinx/eclipsephp-common#3 before review. |
|
@SlimDeluxe Should be good to review this |
|
@SlimDeluxe Let's merge this PR first DataLinx/eclipsephp-common#9 to fix the broken assets issue that you mentioned in the jira. |
|
@SlimDeluxe After that you we can review this PR |
SlimDeluxe
left a comment
There was a problem hiding this comment.
Please resolve the conflicts here.
|
@thapacodes4u please resolve the conflicts and see about the tests failing. |
Related Ticket