Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
============================================
- Coverage 38.37% 37.82% -0.56%
- Complexity 1425 1436 +11
============================================
Files 104 104
Lines 6673 6679 +6
============================================
- Hits 2561 2526 -35
- Misses 4112 4153 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SlimDeluxe
left a comment
There was a problem hiding this comment.
Everything seems ok, except the fact you removed tenant isolation from the tax class resource for some reason 😄
Tax classes must remain tenant-scoped, they are not shared between tenants. Think of a multi-store project, where each site targets one country, and that country has different and unrelated tax classes (e.g VAT in Slovenia is 22%, but in Croatia it's 25%).
So please revert this change.
SlimDeluxe
left a comment
There was a problem hiding this comment.
Conflicts in need of resolution :)
No description provided.