Conversation
Member
|
Just curious, most of the files changed are simply using imports instead of FQCN names for classes in the code. How was this triggered? By the upgrade tool, your editor... ? |
SlimDeluxe
requested changes
Sep 26, 2025
Member
SlimDeluxe
left a comment
There was a problem hiding this comment.
Same here, please update the tests workflow.
Contributor
Author
|
@SlimDeluxe correct, these changes are from the upgrade tool from filament. it sucks it didn’t really fix much stuff (had to do it manually), only changed these imports and told me what to upgrade in the composer |
SlimDeluxe
requested changes
Sep 26, 2025
Member
SlimDeluxe
left a comment
There was a problem hiding this comment.
- There's an error on the users page (wrong class import)
-
getPermissionPrefixes()do not seem to be respected anymore, all permission groups now include all permissions for a resource - "My settings" page is now half the width
- There's an error on the profile page
Member
|
I see the test failing since it's pulling the common package from the main branch on upstream.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.