chore(deps): bump datazoo-oauth2 for the browser-detection fix - #247
Merged
Merged
Conversation
Picks up DataZooDE/datazoo-oauth2#11, which stops a headless session waiting out the full OAuth2 callback timeout for a browser that was never going to open. Before this, any Datasphere call with an expired token cost 60 seconds and ended in "Timeout waiting for OAuth2 callback" - naming neither the expired token nor the absent browser. Three causes: the forked xdg-open's exit status was discarded, nothing checked whether a browser was reachable at all, and the failure was written only to the trace, which is off by default. Verified through the extension against exactly that case: the instructions now say the URL must be opened manually rather than promising an automatic open, the reason is printed, and xdg-open's own "no method available" noise is gone because the doomed opener is no longer run. 3108 assertions in 578 test cases against this bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule bump for DataZooDE/datazoo-oauth2#11 (merged).
What it fixes
A Datasphere call with an expired token on a headless session cost 60 seconds and ended in
Timeout waiting for OAuth2 callback— which named neither the expired token nor the real problem, that no browser exists here.Three causes, all confirmed in the code:
OpenUrlLinuxforked,execlp'dxdg-open, thenwaitpid'd withWNOHANGand discarded the status — so a non-zero exit looked exactly like success.Verified through the extension
Against exactly the failing case:
ssh -Lhint for remote machinesxdg-open's ownno method availablenoise is gone, because the doomed opener is no longer run3108 assertions in 578 test cases pass against this bump.
Note
This unblocks investigating #244: with an expired token the failure is now immediate and explains itself, rather than three 60-second hangs with a misleading error — which is how the defect was found in the first place.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.