Skip to content

chore(deps): bump datazoo-oauth2 for the browser-detection fix - #247

Merged
jrosskopf merged 1 commit into
mainfrom
fix/bump-oauth2-browser-detection
Sep 19, 2026
Merged

jrosskopf merged 1 commit into
mainfrom
fix/bump-oauth2-browser-detection

Conversation

@jrosskopf

@jrosskopf jrosskopf commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Submodule bump for DataZooDE/datazoo-oauth2#11 (merged).

What it fixes

A Datasphere call with an expired token on a headless session cost 60 seconds and ended in Timeout waiting for OAuth2 callback — which named neither the expired token nor the real problem, that no browser exists here.

Three causes, all confirmed in the code:

  • OpenUrlLinux forked, execlp'd xdg-open, then waitpid'd with WNOHANG and discarded the status — so a non-zero exit looked exactly like success.
  • Nothing checked whether a browser was reachable at all before trying.
  • The failure was written only to the trace, which is off by default, so the user saw no explanation.

Verified through the extension

Against exactly the failing case:

  • the instructions say the URL must be opened manually, instead of promising an automatic open and then contradicting themselves
  • the reason is printed on the console, with the URL and an ssh -L hint for remote machines
  • xdg-open's own no method available noise is gone, because the doomed opener is no longer run

3108 assertions in 578 test cases pass against this bump.

Note

This unblocks investigating #244: with an expired token the failure is now immediate and explains itself, rather than three 60-second hangs with a misleading error — which is how the defect was found in the first place.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Picks up DataZooDE/datazoo-oauth2#11, which stops a headless session waiting
out the full OAuth2 callback timeout for a browser that was never going to
open.

Before this, any Datasphere call with an expired token cost 60 seconds and
ended in "Timeout waiting for OAuth2 callback" - naming neither the expired
token nor the absent browser. Three causes: the forked xdg-open's exit status
was discarded, nothing checked whether a browser was reachable at all, and the
failure was written only to the trace, which is off by default.

Verified through the extension against exactly that case: the instructions now
say the URL must be opened manually rather than promising an automatic open,
the reason is printed, and xdg-open's own "no method available" noise is gone
because the doomed opener is no longer run.

3108 assertions in 578 test cases against this bump.
@jrosskopf
jrosskopf merged commit 8c482cf into main Sep 19, 2026
73 checks passed
@jrosskopf
jrosskopf deleted the fix/bump-oauth2-browser-detection branch September 19, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant