Skip to content

fix: backup config/log endpoints #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pyon12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: backup config/log endpoints #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lium/sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,10 +1120,8 @@ def backup_config(self, pod: PodInfo) -> Optional[BackupConfig]:
Returns:
:class:`BackupConfig` if present, otherwise ``None``.
"""
if not pod.executor:
raise ValueError(f"Pod {pod.name} has no executor information")
try:
response = self._request("GET", f"/backup-configs/pod/{pod.executor.id}").json()
response = self._request("GET", f"/backup-configs/pod/{pod.id}").json()
return self._dict_to_backup_config(response) if response else None
except LiumNotFoundError:
# No backup config exists for this pod
Expand All @@ -1147,11 +1145,9 @@ def backup_logs(self, pod: PodInfo) -> List[BackupLog]:
Returns:
List of :class:`BackupLog` entries (possibly empty).
"""
if not pod.executor:
raise ValueError(f"Pod {pod.name} has no executor information")

try:
response = self._request("GET", f"/backup-logs/pod/{pod.executor.id}").json()
response = self._request("GET", f"/backup-logs/pod/{pod.id}").json()

# Handle paginated response - extract items from the response
if isinstance(response, dict) and 'items' in response:
Expand Down