Bump vitest to 4.1.11 to clear GHSA-82fw-gwwq-j7x9 - #36
Merged
Merged
Conversation
The CI "Audit dependencies" step runs npm audit --audit-level=moderate and fails on @vitest/mocker, which is vulnerable to path traversal / arbitrary file read via the redirect mock in the range 2.1.0 - 4.1.10. The lockfile resolved 4.1.6 through vitest. vitest was declared ^4.1.6 both before and after the Build Toward the Whole series, so the range is unchanged by that work; the advisory was published against a dependency the series never touched. Raise the declared floor to ^4.1.11 rather than only refreshing the lockfile, so a future resolution cannot land back inside the vulnerable range. npm audit reports 0 vulnerabilities and npm run ci passes end to end: lint, 42 test files / 300 tests, build, and bundle budget.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the
Audit dependenciesCI failure onmain.Problem
npm audit --audit-level=moderatefails on@vitest/mocker— GHSA-82fw-gwwq-j7x9, path traversal / arbitrary file read via the redirect mock, affecting2.1.0 - 4.1.10. The lockfile resolved4.1.6viavitest.Not caused by the Build Toward the Whole series:
vitestwas^4.1.6before and after it. The advisory landed against an untouched dependency.Fix
Declared floor raised to
^4.1.11(rather than only refreshing the lockfile) so a future resolution cannot fall back into the vulnerable range.Verification
npm audit --audit-level=moderate— 0 vulnerabilitiesnpm run ci— lint, 42 test files / 300 passed (1 skipped), build, bundle budget, all passRun under Node 22 per
.nvmrc.