Phase 6: workspace, web clipper, and folder reconciliation - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb5aa18662
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (['clipper', 'clipboard'].includes(intakeUrl.searchParams.get('capture'))) { | ||
| window.history.replaceState(window.history.state, '', `${intakeUrl.pathname}${intakeUrl.hash}`); | ||
| void this.#openClipperIntake(intakeUrl.href).catch((error) => { |
There was a problem hiding this comment.
Preserve the intake URL until the clipper consumes it
When the bookmarklet opens the app with ?capture=clipper or ?capture=clipboard, this clears the query before the asynchronous intake handler runs, while #openClipperIntake also ignores the intakeUrl.href argument passed here. Phase6Controller.openClipperIntake() consequently reads the already-cleaned window.location.href, returns matched: false, and never opens Quick Capture, so every real bookmarklet launch loses its payload. Forward the captured URL through the wrapper or let the controller clear it after consumption.
Useful? React with 👍 / 👎.
Summary
Verification