Skip to content

Phase 6: workspace, web clipper, and folder reconciliation - #1

Merged
DaveHomeAssist merged 2 commits into
mainfrom
codex/noteforge_phase6
Aug 20, 2026
Merged

DaveHomeAssist merged 2 commits into
mainfrom
codex/noteforge_phase6

Conversation

@DaveHomeAssist

Copy link
Copy Markdown
Owner

Summary

  • add durable single-writer tabs and two-pane workspace
  • add explicit-review web clipper intake and bookmarklet
  • add deterministic, backup-gated Markdown folder reconciliation
  • add Phase 6 Node, browser, mobile, accessibility, scale, and offline coverage

Verification

  • Node 22: 417 checks passed
  • Browser: 394 component + 108 integrated + 10 production/offline checks passed
  • Build: 170 modules; 256,896-byte initial shell
  • Audit: 0 vulnerabilities

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb5aa18662

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/app/main.js
Comment on lines +87 to +89
if (['clipper', 'clipboard'].includes(intakeUrl.searchParams.get('capture'))) {
window.history.replaceState(window.history.state, '', `${intakeUrl.pathname}${intakeUrl.hash}`);
void this.#openClipperIntake(intakeUrl.href).catch((error) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the intake URL until the clipper consumes it

When the bookmarklet opens the app with ?capture=clipper or ?capture=clipboard, this clears the query before the asynchronous intake handler runs, while #openClipperIntake also ignores the intakeUrl.href argument passed here. Phase6Controller.openClipperIntake() consequently reads the already-cleaned window.location.href, returns matched: false, and never opens Quick Capture, so every real bookmarklet launch loses its payload. Forward the captured URL through the wrapper or let the controller clear it after consumption.

Useful? React with 👍 / 👎.

@DaveHomeAssist
DaveHomeAssist merged commit 690fc75 into main Aug 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant