Phase 7 integration hardening - #3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d26f68137
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stage = 'updating one task/property source incrementally'; | ||
| await page.evaluate(async () => { | ||
| const note = window.app.db.getNote('phase7-task'); | ||
| note.update({ content: '---\nstatus: reviewed\n---\n# Work\n\n- [ ] Phase7 updated task @due(2026-08-21)' }); |
There was a problem hiding this comment.
The Calendar opens on the current local month, but this fixture always assigns the updated task to 2026-08-21 and then expects its text in the visible calendar. When the browser suite runs outside August 2026, that item is outside the rendered period, so npm run test:browser fails despite correct application behavior. Generate a date in the current month or explicitly open the Calendar on this fixed date.
Useful? React with 👍 / 👎.
|
|
||
| refresh() { | ||
| this.items = buildCalendarItems(this.db.getAllNotes()); | ||
| this.items = this.index.list(); |
There was a problem hiding this comment.
Calling buildCalendarItems([note]) per source sorts only each note's records, while NoteDerivedIndex.list() concatenates those arrays in vault insertion order. The previous buildCalendarItems(this.db.getAllNotes()) globally sorted items by date, note title, and ID, so multiple notes on the same day now appear in insertion order and a rename does not reposition them. Sort the flattened indexed result using the same ordering before rendering.
Useful? React with 👍 / 👎.
GitHub Actions
Inactive
1 participant
Summary
Verified locally
npm test— 425 checks, zero failuresnpm run test:browser— 394 component assertions, 120 integrated workflows, ten production/offline checksnpm run build— 172 modules; 257,023-byte initial shell (157 bytes below ceiling)npm audit --audit-level=high— zero vulnerabilitiesgit diff --check— cleanPending release gate