Skip to content

Anchor the Phase 7 due-date fixture to the current month - #5

Merged
DaveHomeAssist merged 1 commit into
mainfrom
fix/phase7-calendar-due-date
Sep 10, 2026
Merged

DaveHomeAssist merged 1 commit into
mainfrom
fix/phase7-calendar-due-date

Conversation

@DaveHomeAssist

Copy link
Copy Markdown
Owner

Clears the Deploy NoteForge failure on main.

Problem

The Phase 7 cross-feature smoke hardcoded @due(2026-08-21) in both the fixture note and its incremental update, then asserted the Calendar overlay lists the updated task:

check('open Calendar reflects the same incrementally updated due task',
  /Phase7 updated task/.test(await page.locator('#calendar-overlay').innerText()));

The Calendar anchors on today and its agenda renders only items inside the visible period, so that assertion could only hold while the wall clock was inside August 2026. It passed in CI on 2026-08-20 and has failed every run since the month rolled over — a time-bomb fixture, not a regression.

Confirmed pre-existing: the identical failure reproduces on becbffa, the base commit before the Build Toward the Whole series, with the other 393 checks passing.

Fix

Compute the due date from the current date — the same idiom the Phase 4 fixture already uses — and thread it through to the update step, so the task always lands inside the period the Calendar renders.

Verification

node test/run-features.mjs394/394 pass (previously 393 pass, 1 fail).

The Phase 7 cross-feature smoke hardcoded @Due(2026-08-21) in both the
fixture note and its incremental update, then asserted that the Calendar
overlay lists the updated task. The Calendar anchors on today and its agenda
only renders items inside the visible period, so the assertion could only
hold while the wall clock was inside August 2026. It passed in CI on
2026-08-20 and has failed every run since the month rolled over.

This is not drift from the Build Toward the Whole series: the same failure
reproduces on becbffa, the unpatched base, with the other 393 browser
checks passing.

Compute the due date from the current date the way the Phase 4 fixture
already does, and thread it through to the update step, so the task always
falls inside the period the Calendar renders. Browser feature tests:
394/394 pass.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@DaveHomeAssist
DaveHomeAssist merged commit 5629450 into main Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant