Anchor the Phase 7 due-date fixture to the current month - #5
Merged
Merged
Conversation
The Phase 7 cross-feature smoke hardcoded @Due(2026-08-21) in both the fixture note and its incremental update, then asserted that the Calendar overlay lists the updated task. The Calendar anchors on today and its agenda only renders items inside the visible period, so the assertion could only hold while the wall clock was inside August 2026. It passed in CI on 2026-08-20 and has failed every run since the month rolled over. This is not drift from the Build Toward the Whole series: the same failure reproduces on becbffa, the unpatched base, with the other 393 browser checks passing. Compute the due date from the current date the way the Phase 4 fixture already does, and thread it through to the update step, so the task always falls inside the period the Calendar renders. Browser feature tests: 394/394 pass.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the
Deploy NoteForgefailure onmain.Problem
The Phase 7 cross-feature smoke hardcoded
@due(2026-08-21)in both the fixture note and its incremental update, then asserted the Calendar overlay lists the updated task:The Calendar anchors on today and its agenda renders only items inside the visible period, so that assertion could only hold while the wall clock was inside August 2026. It passed in CI on 2026-08-20 and has failed every run since the month rolled over — a time-bomb fixture, not a regression.
Confirmed pre-existing: the identical failure reproduces on
becbffa, the base commit before the Build Toward the Whole series, with the other 393 checks passing.Fix
Compute the due date from the current date — the same idiom the Phase 4 fixture already uses — and thread it through to the update step, so the task always lands inside the period the Calendar renders.
Verification
node test/run-features.mjs— 394/394 pass (previously 393 pass, 1 fail).