Don't set rcc.ahb2rstr.adcrst bit when initializing ADCs on L4x5/L4x6#162
Merged
David-OConnor merged 1 commit intoDavid-OConnor:mainfrom Dec 3, 2025
Merged
Don't set rcc.ahb2rstr.adcrst bit when initializing ADCs on L4x5/L4x6#162David-OConnor merged 1 commit intoDavid-OConnor:mainfrom
David-OConnor merged 1 commit intoDavid-OConnor:mainfrom
Conversation
… as this causes the previously-configured ADC registers to be lost
Owner
|
Good fix; I concur on all of the above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring multiple ADCs (i.e. ADC1 and ADC2) via the new_adc function, all but the last ADC will be reset. This is because the library calls
rcc_en_resetby default, even though it isn't appropriate in this instance. Like the h7 and g4 code, I've added code to manually set the enable register rather than calling the rcc_en_reset macro.