Skip to content

Inherit HOMEgfs and set HOMEglobal in ecf scripts#57

Merged
DavidHuber-NOAA merged 2 commits intofeature/homeglobal_17from
copilot/inherit-homegfs-in-ecf-scripts
Apr 27, 2026
Merged

Inherit HOMEgfs and set HOMEglobal in ecf scripts#57
DavidHuber-NOAA merged 2 commits intofeature/homeglobal_17from
copilot/inherit-homegfs-in-ecf-scripts

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 27, 2026

Description

All ECF scripts under ecf/scripts/ were missing export HOMEglobal=${HOMEgfs}, which is required for J-Jobs to locate the correct home directory. This follows the pattern already established in the GCAFS scripts.

Changes:

  • Added export HOMEglobal=${HOMEgfs} to all 80 ECF scripts under ecf/scripts/gfs/, ecf/scripts/gdas/, and ecf/scripts/enkfgdas/
    • Scripts with CDATE: inserted immediately after export CDATE=${PDY}${cyc}
    • FSM scripts (no CDATE): inserted immediately before the J-Job call
  • cycle_end.ecf excluded — does not call a J-Job

Example (before → after in a typical script):

export CDATE=${PDY}${cyc}
+export HOMEglobal=${HOMEgfs}
${HOMEgfs}/jobs/JGLOBAL_FORECAST

Resolves #56

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • Code review and diff inspection confirming exactly one line added per script, in the correct location

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Agent-Logs-Url: https://github.com/DavidHuber-NOAA/global-workflow/sessions/21d73af1-b28d-496f-8e81-373b2fdadcc2

Co-authored-by: DavidHuber-NOAA <69919478+DavidHuber-NOAA@users.noreply.github.com>
Copilot AI changed the title [WIP] Update ecf scripts to inherit HOMEgfs and set HOMEglobal Inherit HOMEgfs and set HOMEglobal in ecf scripts Apr 27, 2026
Copilot AI requested a review from DavidHuber-NOAA April 27, 2026 13:05
@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review April 27, 2026 13:17
@DavidHuber-NOAA DavidHuber-NOAA merged commit fc406c2 into feature/homeglobal_17 Apr 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inherit HOMEgfs in the ecf scripts

2 participants