Conversation
|
@Lftobs is attempting to deploy a commit to the Cypheron 's projects team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
Include detailed system design, payment infrastructure overview, and webhook reconciliation logic in docs/architecture.md and reference it in the README.
environment-dependent Lower the minimum payment threshold to ₦20.00 in development mode to facilitate easier testing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the documentation and payment processing logic, as well as enhancements to test coverage and error handling. The most notable changes include the addition of a comprehensive architecture guide, dynamic minimum funding thresholds based on environment, improved payout source account selection, and stricter payment status checks.
Documentation Updates:
docs/architecture.mdfile documenting the platform's high-level design, payment infrastructure, webhook reconciliation, deployment, and architectural decisions, especially the rationale for using virtual account funding instead of subscriptions.README.mdto include an "Architecture" section, linking to the new architecture documentation and summarizing key design choices. [1] [2]Payment Processing Improvements:
require_confirmed_session_paymentfunction now raises an explicit error if any payment is marked as "failed" or "reversed", providing clearer feedback to clients.Test Coverage Updates:
test_reconciliation.pyto match the new minimum funding threshold logic, ensuring that the tests accurately reflect both development and production settings. [1] [2] [3]