fix(runner): drain terminal responses after child exits#68
Closed
DecampsRenan wants to merge 1 commit into
Closed
Conversation
Run commands as subprocess instead of replacing via syscall.Exec, so spm can drain pending terminal escape responses (DECRPM, cursor pos…) left in stdin when TUI-style commands like turbo are killed by Ctrl+C. Without this drain, those bytes leak into the shell and surface as random characters at the next prompt. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
Closing — root cause is upstream (turbo not restoring terminal on Ctrl+C); the workaround only covers the spm-in-the-chain case. Reverting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runner.Runfromsyscall.Execto a subprocess execution model so spm survives the child's exitturboTest plan
go test ./...passes (existing SIGINT/SIGTERM exit-code tests still green)spm devin a turbo project, Ctrl+C, confirm shell prompt is clean🤖 Generated with Claude Code