[codex] finish sensitive mode desktop stage#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protect_nowrows, while desktop/browser surfaces are visible as non-toggleable Coming Soon rows.script/build_and_run.shto build thelucairndsidecar, bundle the Tauri app, launch it, and verify the running process.Why
The previous approach mixed supported API-mode paths with desktop/browser paths that are not production-ready. This made the app look broader than what it could prove. This PR makes the useful slice reliable and honest while keeping the full interception promise visible as roadmap.
Validation
cd lucairnd && go test ./...cd ui/src-tauri && cargo testcd ui && pnpm typecheck && pnpm test && pnpm validate:aicd ui && pnpm lintbash -n script/build_and_run.sh./script/build_and_run.sh --verifyThe
--verifypath built the.appand.dmg, launched the app bundle, and verified thelucairn-sensitive-modeprocess.