ci: Consolidate build and test into single CI workflow#84
Merged
bensonwong merged 5 commits intomainfrom Jan 23, 2026
Merged
Conversation
1. **TypeScript error at line 314** - The build now passes successfully. The error you mentioned (`Type 'boolean | undefined' is not assignable to type 'boolean'`) appears to have been fixed in a previous commit. 2. **Created build workflow** - Added `.github/workflows/build.yml` that: - Runs on PR to main and push to main (same triggers as test.yml) - Uses the same Blacksmith runner - Installs dependencies with bun - Runs `bun run build` The build workflow will now run alongside the test workflow to catch build failures in CI.
bensonwong
changed the title
- Renamed test.yml to ci.yml - Added build step before tests - Removed separate build.yml to avoid running two instances Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bensonwong
changed the title
bun install doesn't properly handle Rollup's platform-specific optional dependencies (@rollup/rollup-linux-x64-gnu), causing build failures. Switch to npm install which handles these correctly. Keep bun for running tests since it's faster for test execution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The `hasLowTrustMatch` variable could be `boolean | undefined` when `verification.searchAttempts` is undefined, causing TypeScript errors when returning CitationStatus which requires all boolean fields. Added `?? false` to ensure the value is always boolean. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines build and test steps into a single CI workflow, reducing runner usage and simplifying the pipeline.
Changes
.github/workflows/test.yml→.github/workflows/ci.ymlbun run buildstep before running testsbuild.ymlworkflowWhy
Running build and test in a single workflow: