Skip to content

docs(verify): drop --browser from login command in auth rules#18

Merged
bensonwong merged 1 commit intomainfrom
fix/verify-auth-login-command
Apr 10, 2026
Merged

docs(verify): drop --browser from login command in auth rules#18
bensonwong merged 1 commit intomainfrom
fix/verify-auth-login-command

Conversation

@bensonwong
Copy link
Copy Markdown
Contributor

@bensonwong bensonwong commented Apr 10, 2026

Summary

  • The deepcitation login command opens the browser by default now, so the --browser flag is redundant in the auth self-recovery instructions.
  • Also re-normalizes skills/verify/rules/auth.md to LF (was reverted to CRLF by an editor after the earlier normalization in 86da39a).

Test plan

  • Verify npx -y deepcitation@latest login still works without the --browser flag
  • Confirm file line endings are LF (file skills/verify/rules/auth.md)

The `deepcitation login` command opens the browser by default now,
so the `--browser` flag is no longer needed in the auth self-recovery
instructions. Also re-normalizes the file to LF (was reverted to CRLF
by an editor after the earlier normalization in 86da39a).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude bot commented Apr 10, 2026

PR Review

Overall: LGTM - clean, minimal doc update.

Changes:

  1. --browser flag removal: Correctly removes the redundant flag from the OAuth login command. Since the default behavior already opens the browser, the flag is noise. No functional regression risk as this is a documentation-only change.

  2. Line ending normalization (CRLF to LF): Good hygiene. If the repo does not have a .gitattributes entry enforcing LF for this file, an editor could silently re-introduce CRLF again (as happened after 86da39a). Consider adding a rule like asterisk.md text eol=lf to .gitattributes to prevent a third revert, which would address the root cause.

No concerns on security (no credential handling changed), logic (OAuth flow description is still accurate, only the redundant flag was removed), or the test plan (the two checklist items are appropriate).

Minor suggestion: pair this PR with a .gitattributes fix to enforce LF on markdown files, since the CRLF issue has now recurred twice.

@bensonwong bensonwong merged commit c448d3a into main Apr 10, 2026
1 check passed
@bensonwong bensonwong deleted the fix/verify-auth-login-command branch April 10, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant