Skip to content

Port OOC shuttle call vote - #102

Open
nlaky wants to merge 3 commits into
DeltaV-Station:masterfrom
nlaky:ooc-roundend-vote
Open

Port OOC shuttle call vote#102
nlaky wants to merge 3 commits into
DeltaV-Station:masterfrom
nlaky:ooc-roundend-vote

Conversation

@nlaky

@nlaky nlaky commented Aug 3, 2026

Copy link
Copy Markdown

About the PR

Ported shuttle call voting system.
Taken from DeltaV-Station/Delta-v#3766 and DeltaV-Station/Delta-v#5568

Why / Balance

Closes #84

Technical details

Port of old code, with a few modifications:

  • Resolved merge conflict with upstream RoundEndSystem now already being partial.
  • Change call to RoundEndSystem.RequestRoundEnd() (interface changed since initial implementation)
  • Move all files into _DVA/ from _DV/

Test plan

  1. Change auto-call time CCVar to something short (~2 minutes)
  2. Change auto-call extension time CCVar to something short
  3. Run release build, load map, and wait for shuttle call vote
  4. Test that vote win/tie calls shuttle
  5. Test that vote fail does not call, and that it holds an additional vote later

Media

image

Requirements

  • I have tested this pull request and written instructions on how to test it
  • I have added media to this PR or it does not require an in-game showcase.

Licensing

Changelog

🆑

  • add: Emergency shuttle call OOC vote

@nlaky
nlaky requested a review from a team as a code owner August 3, 2026 18:51
ShepardToTheStars
ShepardToTheStars reviewed Aug 10, 2026
View reviewed changes
Comment thread Content.Server/_DVA/RoundEnd/RoundEndSystem.cs Outdated
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

nlaky and others added 2 commits August 11, 2026 04:36
@nlaky
Add OOC shuttle call vote
72a7fb3
@nlaky @ShepardToTheStars
Change call to RequestRoundEnd
9a26a0d 
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
@nlaky
nlaky force-pushed the ooc-roundend-vote branch from 82e4e9a to 9a26a0d Compare August 11, 2026 10:40
ShepardToTheStars
ShepardToTheStars reviewed Aug 11, 2026
View reviewed changes
Comment thread Content.Server/_DVA/RoundEnd/RoundEndSystem.EvacVote.cs
StarboundSolaris pushed a commit to StarboundSolaris/Solaris-Turbo-Touhou-Skibidi-Turbo-Bullshit-Development-Repo-Of-Doom-And-Despair that referenced this pull request Aug 14, 2026
@metalgearsloth
Fix ItemGridPiece using invalid sprite bounds (DeltaV-Station#102)
0bbf402 
It inverted bottom and top.
StarboundSolaris pushed a commit to StarboundSolaris/Solaris-Turbo-Touhou-Skibidi-Turbo-Bullshit-Development-Repo-Of-Doom-And-Despair that referenced this pull request Aug 14, 2026
@metalgearsloth @RemFexxel
@Princess-Cheeseballs @riccardi48 @Tayrtahn @jessicamaybe @whatston3 @mnva0 @ScarKy0 @chromiumboy @VerinSenpai @kontakt @portfiend @rumaks-xyz @ArtisticRoomba @iaada @ThatGuyUSA @insoPL @AndrewFenriz @SlamBamActionman @murolem @korczoczek @B-Kirill @Pok27 @JoshGreenslade Josh Greenslade @YoungThugSS14
Master temporary repository into the main repository (#44378)
1e6863f 
* Update README.md with new links. (DeltaV-Station#2)

* Update README.md with new links.

* Update README.md with Princess-Cheeseballs' provided links.

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>

* Removed an extra space.

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>

* Update actions_changelog_rss.py with the new domain.

* Update stylesheet.xsl

* Update SECURITY.md

---------

Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>

* fix (DeltaV-Station#14)

* Switch RT submodule to new repo (DeltaV-Station#19)

* Remove toggle action from winter coat (DeltaV-Station#24)

* i think i got them all

* minor cleanup

* init (DeltaV-Station#13)

* Bugfix: Moproach/spider solution regeneration (DeltaV-Station#41)

* moproach/spider solutions with recharge

* mop mop mop roach

* more straightforward moproach solution inheritance

* Adds temperature protection to scarves (DeltaV-Station#47)

* Adds temperature protection to scarves

* YAML conventions say specific stuff is better at the bottom

* Remove scream action, replace with emote action (DeltaV-Station#55)

* no mroe screaming

* if your angry and you know it scream with action grant! *clap clap*

* emote action is more generic now

* use flag instead

* Revert "if your angry and you know it scream with action grant! *clap clap*"

This reverts commit 7c40ee48

* screaming im screaming im screaming

* reversed oops

* Fix handheld grinders (DeltaV-Station#50)

* fix

* TEST!!!!!!!!!!

* comment

* what

* im so silly

* explosion!!!!!

* i hate tests

* those can be asserts too

* i hate tests

* Replace all uses of System.Random with IRobustRandom, resolve all System.Random warnings. (DeltaV-Station#32)

* Remove all uses of System.Random

* Use IRobustRandom in BinomialNumberSelector.Get

* Remove remaining ToolRefinableSystem S.Random inst

* Arcade sprite fixes & metadata cleanup (DeltaV-Station#40)

* arcade sprite & metadata cleanup

* 4 space meta.json

* Bring cargo order menu to the front when selecting a new item

* Bugfix: Remove infinite board dupe in television/telescreen construction graphs. (DeltaV-Station#42)

* Fix telescreen/wallmount TV dupe

* fix tagged icons

* Initial commit (DeltaV-Station#3)

* Fix blankline after games rules (DeltaV-Station#77)

Annoyed me.

* Fix illegible FileNotFoundError occurrences when git isn't in path. (DeltaV-Station#6)

* Update git_helper.py

* Update git_helper.py

* Update git_helper.py

* Make borgs not RR (DeltaV-Station#84)

* Cargo integration tests update (DeltaV-Station#18)

* Updated Cargo Integration Tests

* usings

* revert NoCargoOrderArbitrage

* unneeded ;

* .

* review requests

* review requests v2

* Move server_fans.ogg to a SoundCollection (DeltaV-Station#82)

* quieter server fans

* Restore individual parameter fields

* Document Client, Server, and Shared files in folders starting with "K". Except microwaves. (DeltaV-Station#91)

* document the entire owl

* Apply suggestions from code review

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Can cancel orders from the console you placed it on (DeltaV-Station#11)

* Make `InteractionTest` inherit from `GameTest` (DeltaV-Station#90)

* Make InteractionTest inherit from GameTest

* Convert MousetrapTest to use some GameTest features

* Document stubbed Setup method

* LoadTestMap now sets TestMap like CreateTestMap

* Maybe fix?

* Oh, derp

* Fix approval section on order labels always being "Self" (DeltaV-Station#15)

* Fixed label bug

* review request

* Add FixturesComponent to BaseWallmount (DeltaV-Station#81)

* BUI template (DeltaV-Station#57)

* Remove tasers from security locker fills (DeltaV-Station#67)

* Ambient Music fixes and tweaks (DeltaV-Station#28)

* reorganize yml

* medical and engineering marker components and mass marking

* bed

* increase cooldown

* did i leave that in

* Renames all EntitySystem "ProtoMan" instances (DeltaV-Station#100)

* Remove "ProtoMan" instances

* guess we're caching gases now

* Microoptimize Vector2i.Offset (DeltaV-Station#103)

* microopt offset
works on my machine award

* tweaks

* Fix event horizons using negative radius (DeltaV-Station#105)

Not even valid why is it NEGATIVE just use ZERO!

* Fix ItemGridPiece using invalid sprite bounds (DeltaV-Station#102)

It inverted bottom and top.

* Atmos category in the construction menu (DeltaV-Station#94)

* commit

* move on over

---------

Co-authored-by: iaada <iaada@users.noreply.github.com>

* Space Law Revision (DeltaV-Station#1)

* Update SpaceLaw.xml

* Update SLCrimeList.xml

* Update SpaceLaw.xml to reflect AJCM-git's suggestion.

* fixed (#128)

* Directional arrow (#118)

* arrow

* yoink orginal arrow rsi

* done

* fixes

* i just learnd about ignored components

* Update Content.Client/DirectionalArrowIndicator/DirectionalArrowIndicatorComponent.cs

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>

* customArrows

* docs

* more docs

* teg and blue arrow

* misc

* fixes

* remove color

* imma dummy

* meta

* soon to obsolete

* class not partial

---------

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>

* Update RT to 277.2.0 (#138)

* Refactor RecipeManager to use LINQ and PrototypesReloaded (DeltaV-Station#49)

* small refactor RecipeManager and fix prototype reloading

* wait... why is that here?

* maybe?

* Add section to link to space-wizards PR URL to PR template (#143)

* Construction menu recipe history (DeltaV-Station#8)

* Bugfix: Fix DrawDepth subfloor gap width, add gap for mapping subfloor layers (DeltaV-Station#70)

* Hide artifact effects from spawnmenu (#149)

* [FIX] Make slices of food fill out the space where the whole food used to be instead of dropping onto the floor (#160)

* Add NU1900 to WarningsNotAsErrors (#171)

* Removed duplicate function from solutions refactor in pricing system (#164)

* Hide virtual items in cryoUI (#175)

Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>

* Add Integration test for ExpireIdCardComponent (#162)

Co-authored-by: Josh Greenslade <joshua.greenslade@onyxinsight.com>
Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>

* Remove Staff of Entrance from Magic Event Spell (#114)

* fix atmosphere system protoman

* Revert "Update README.md with new links. (DeltaV-Station#2)"

This reverts commit dffabf7.

* Revert "Switch RT submodule to new repo (DeltaV-Station#19)"

This reverts commit 1000a7b.

* Revert "Add section to link to space-wizards PR URL to PR template (#143)"

This reverts commit 48201fc.

---------

Co-authored-by: Rem <GitRem@grifton.lol>
Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
Co-authored-by: riccardi48 <39341154+riccardi48@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: Jessica M <jessica@jessicamaybe.com>
Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Minerva <218184747+mnva0@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Kyle Tyo <akikai297@gmail.com>
Co-authored-by: Connor Huffine <chuffine@gmail.com>
Co-authored-by: portfiend <109661617+portfiend@users.noreply.github.com>
Co-authored-by: rumaks <me@rumaks.xyz>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: iaada <iaada@users.noreply.github.com>
Co-authored-by: ThatGuyUSA <thatguyusa123@gmail.com>
Co-authored-by: InsoPL <lukasz.lindert@protonmail.com>
Co-authored-by: AndrewFenriz <78079974+AndrewFenriz@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Vladislav Suchkov <20380250+murolem@users.noreply.github.com>
Co-authored-by: korczoczek <danielkorczok@gmail.com>
Co-authored-by: B_Kirill <153602297+B-Kirill@users.noreply.github.com>
Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com>
Co-authored-by: JoshGreenslade <joshgreenslade@gmail.com>
Co-authored-by: Josh Greenslade <joshua.greenslade@onyxinsight.com>
Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
Co-authored-by: Rami <ramialanbagy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShepardToTheStars ShepardToTheStars ShepardToTheStars left review comments

Assignees

No one assigned

Labels

S: Needs Review S: Untriaged size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Round end OOC vote

2 participants

@nlaky @ShepardToTheStars