avaaaali by sowelipililimute · Pull Request #103 · DeltaV-Station/Acceleration

sowelipililimute · 2026-08-03T22:45:43Z

About the PR

Well, the first species being brought over.

Technical details

DVGenericColorVisuals: generic visualizer for layer colour data because frankly im shocked this didnt exist yet
DVInnateEyeOffset: system that augments EyeCursorOffset w/ toggling
- DVToggleInnateEyeOffsetEvent for actions
DVPreenableComponent: handles spawning feathers w/ the right data and also the verb w/ a do-after
DVPreenOnDamaged: handles specifically triggering preens when hit by damage
also the species are structured differently because frankly the upstream way kinda sucks and is hard to see what's related to what

Test plan

spawn as avali
preen yourself
observe the feather being coloured like you
throngle yourself
observe the feather being coloured like you AND it has your blood on it AND also youre getting an adrenaline rush
oh yeah also binoculars are there

Requirements

I have tested this pull request and written instructions on how to test it
I have added media to this PR or it does not require an in-game showcase.

Licensing

I confirm that I sign off on the Developer Certificate of Origin.

github-actions · 2026-08-03T22:46:18Z

RSI Diff Bot; head commit d531853 merging into 0e686ea
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DVA/Mobs/Species/Avali/avali_crests.rsi

State	Old	New	Status
avali_crest_bigponytail_primary			Added
avali_crest_bigponytail_secondary			Added
avali_crest_bigponytail_tertiary			Added
avali_crest_cockatiel_primary			Added
avali_crest_cockatiel_secondary			Added
avali_crest_cockatoo_primary			Added
avali_crest_cockatoo_secondary			Added
avali_crest_dualfeather_primary			Added
avali_crest_dualfeather_secondary			Added
avali_crest_hooked_primary			Added
avali_crest_hooked_secondary			Added
avali_crest_jay_primary			Added
avali_crest_jay_secondary			Added
avali_crest_longfeather_primary			Added
avali_crest_longfeather_secondary			Added
avali_crest_punk_primary			Added
avali_crest_punk_secondary			Added

Resources/Textures/_DVA/Mobs/Species/Avali/avali_parts.rsi

State	Old	New	Status
ears_avalibase_primary			Added
ears_avalibase_secondary			Added
tail_avalibase			Added

Resources/Textures/_DVA/Mobs/Species/Avali/avali_stripes_one.rsi

State	Old	New	Status
ears_bottom_primary			Added
ears_bottom_secondary			Added
ears_top_primary			Added
ears_top_secondary			Added
head_primary			Added
head_secondary			Added
larm_primary			Added
larm_secondary			Added
lhand_primary			Added
lhand_secondary			Added
lleg			Added
rarm_primary			Added
rarm_secondary			Added
rhand_primary			Added
rhand_secondary			Added
rleg			Added
tail_avali_primary			Added
tail_avali_secondary			Added
torso_primary			Added
torso_secondary			Added

Resources/Textures/_DVA/Mobs/Species/Avali/avali_trim_one.rsi

State	Old	New	Status
ears_bottom_primary			Added
ears_bottom_secondary			Added
ears_top_primary			Added
ears_top_secondary			Added
head_primary			Added
head_secondary			Added
larm_primary			Added
larm_secondary			Added
lhand_primary			Added
lhand_secondary			Added
lleg_primary			Added
lleg_secondary			Added
rarm_primary			Added
rarm_secondary			Added
rhand_primary			Added
rhand_secondary			Added
rleg_primary			Added
rleg_secondary			Added
tail_avali_primary			Added
tail_avali_secondary			Added
torso_primary			Added
torso_secondary			Added

Resources/Textures/_DVA/Mobs/Species/Avali/avali_trim_two.rsi

State	Old	New	Status
ears_bottom_primary			Added
ears_bottom_secondary			Added
ears_top_primary			Added
ears_top_secondary			Added
head_primary			Added
head_secondary			Added
larm_primary			Added
larm_secondary			Added
lhand_primary			Added
lhand_secondary			Added
rarm_primary			Added
rarm_secondary			Added
rhand_primary			Added
rhand_secondary			Added
tail_avali_primary			Added
tail_avali_secondary			Added
torso_primary			Added
torso_secondary			Added

Resources/Textures/_DVA/Mobs/Species/Avali/displacement.rsi

State	Old	New	Status
head			Added
mask			Added

Resources/Textures/_DVA/Mobs/Species/Avali/feather.rsi

State	Old	New	Status
equipped-EARS			Added
equipped-HELMET			Added
feather			Added
featherblood			Added

Resources/Textures/_DVA/Mobs/Species/Avali/parts.rsi

State	Old	New	Status
eyes			Added
full			Added
head			Added
l_arm			Added
l_foot			Added
l_hand			Added
l_leg			Added
r_arm			Added
r_foot			Added
r_hand			Added
r_leg			Added
torso			Added

ShepardToTheStars

Species components need to be added to Resources/Prototypes/Entities/Mobs/Player/clone.yml as well.

ShepardToTheStars · 2026-08-10T16:37:38Z

+    [DataField]
+    public EntProtoId FeatherPrototype;


Should this be required?

ShepardToTheStars · 2026-08-10T16:39:11Z

+    [DataField]
+    public EntProtoId FeatherPrototype;


Should this be required?

ShepardToTheStars · 2026-08-10T16:49:11Z

+            if (comp.CurrentFeathers >= comp.MaximumFeathers)
+            {
+                comp.RegenerateAt = null;
+                Dirty(uid, comp);
+            }
+


Missing a continue in the Current >= Max block? Otherwise, an additional feather would get added even if they are at the maximum, right? (but only once since RegenerateAt would be null the next time that entity gets processed.

Alternatively, you could put the Current >= Max check above the comp.RegenerateAt == null as well.

ShepardToTheStars · 2026-08-10T16:51:53Z

+                Dirty(uid, comp);
+            }
+
+            comp.CurrentFeathers += 1;


Thoughts on clamping this to the max?

Suggested change

comp.CurrentFeathers += 1;

comp.CurrentFeathers = Math.Min(comp.CurrentFeathers + 1, comp.MaximumFeathers);

* microopt offset works on my machine award * tweaks

* Update README.md with new links. (DeltaV-Station#2) * Update README.md with new links. * Update README.md with Princess-Cheeseballs' provided links. Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> * Removed an extra space. Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> * Update actions_changelog_rss.py with the new domain. * Update stylesheet.xsl * Update SECURITY.md --------- Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> * fix (DeltaV-Station#14) * Switch RT submodule to new repo (DeltaV-Station#19) * Remove toggle action from winter coat (DeltaV-Station#24) * i think i got them all * minor cleanup * init (DeltaV-Station#13) * Bugfix: Moproach/spider solution regeneration (DeltaV-Station#41) * moproach/spider solutions with recharge * mop mop mop roach * more straightforward moproach solution inheritance * Adds temperature protection to scarves (DeltaV-Station#47) * Adds temperature protection to scarves * YAML conventions say specific stuff is better at the bottom * Remove scream action, replace with emote action (DeltaV-Station#55) * no mroe screaming * if your angry and you know it scream with action grant! *clap clap* * emote action is more generic now * use flag instead * Revert "if your angry and you know it scream with action grant! *clap clap*" This reverts commit 7c40ee48 * screaming im screaming im screaming * reversed oops * Fix handheld grinders (DeltaV-Station#50) * fix * TEST!!!!!!!!!! * comment * what * im so silly * explosion!!!!! * i hate tests * those can be asserts too * i hate tests * Replace all uses of System.Random with IRobustRandom, resolve all System.Random warnings. (DeltaV-Station#32) * Remove all uses of System.Random * Use IRobustRandom in BinomialNumberSelector.Get * Remove remaining ToolRefinableSystem S.Random inst * Arcade sprite fixes & metadata cleanup (DeltaV-Station#40) * arcade sprite & metadata cleanup * 4 space meta.json * Bring cargo order menu to the front when selecting a new item * Bugfix: Remove infinite board dupe in television/telescreen construction graphs. (DeltaV-Station#42) * Fix telescreen/wallmount TV dupe * fix tagged icons * Initial commit (DeltaV-Station#3) * Fix blankline after games rules (DeltaV-Station#77) Annoyed me. * Fix illegible FileNotFoundError occurrences when git isn't in path. (DeltaV-Station#6) * Update git_helper.py * Update git_helper.py * Update git_helper.py * Make borgs not RR (DeltaV-Station#84) * Cargo integration tests update (DeltaV-Station#18) * Updated Cargo Integration Tests * usings * revert NoCargoOrderArbitrage * unneeded ; * . * review requests * review requests v2 * Move server_fans.ogg to a SoundCollection (DeltaV-Station#82) * quieter server fans * Restore individual parameter fields * Document Client, Server, and Shared files in folders starting with "K". Except microwaves. (DeltaV-Station#91) * document the entire owl * Apply suggestions from code review Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Can cancel orders from the console you placed it on (DeltaV-Station#11) * Make `InteractionTest` inherit from `GameTest` (DeltaV-Station#90) * Make InteractionTest inherit from GameTest * Convert MousetrapTest to use some GameTest features * Document stubbed Setup method * LoadTestMap now sets TestMap like CreateTestMap * Maybe fix? * Oh, derp * Fix approval section on order labels always being "Self" (DeltaV-Station#15) * Fixed label bug * review request * Add FixturesComponent to BaseWallmount (DeltaV-Station#81) * BUI template (DeltaV-Station#57) * Remove tasers from security locker fills (DeltaV-Station#67) * Ambient Music fixes and tweaks (DeltaV-Station#28) * reorganize yml * medical and engineering marker components and mass marking * bed * increase cooldown * did i leave that in * Renames all EntitySystem "ProtoMan" instances (DeltaV-Station#100) * Remove "ProtoMan" instances * guess we're caching gases now * Microoptimize Vector2i.Offset (DeltaV-Station#103) * microopt offset works on my machine award * tweaks * Fix event horizons using negative radius (DeltaV-Station#105) Not even valid why is it NEGATIVE just use ZERO! * Fix ItemGridPiece using invalid sprite bounds (DeltaV-Station#102) It inverted bottom and top. * Atmos category in the construction menu (DeltaV-Station#94) * commit * move on over --------- Co-authored-by: iaada <iaada@users.noreply.github.com> * Space Law Revision (DeltaV-Station#1) * Update SpaceLaw.xml * Update SLCrimeList.xml * Update SpaceLaw.xml to reflect AJCM-git's suggestion. * fixed (#128) * Directional arrow (#118) * arrow * yoink orginal arrow rsi * done * fixes * i just learnd about ignored components * Update Content.Client/DirectionalArrowIndicator/DirectionalArrowIndicatorComponent.cs Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> * customArrows * docs * more docs * teg and blue arrow * misc * fixes * remove color * imma dummy * meta * soon to obsolete * class not partial --------- Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> * Update RT to 277.2.0 (#138) * Refactor RecipeManager to use LINQ and PrototypesReloaded (DeltaV-Station#49) * small refactor RecipeManager and fix prototype reloading * wait... why is that here? * maybe? * Add section to link to space-wizards PR URL to PR template (#143) * Construction menu recipe history (DeltaV-Station#8) * Bugfix: Fix DrawDepth subfloor gap width, add gap for mapping subfloor layers (DeltaV-Station#70) * Hide artifact effects from spawnmenu (#149) * [FIX] Make slices of food fill out the space where the whole food used to be instead of dropping onto the floor (#160) * Add NU1900 to WarningsNotAsErrors (#171) * Removed duplicate function from solutions refactor in pricing system (#164) * Hide virtual items in cryoUI (#175) Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> * Add Integration test for ExpireIdCardComponent (#162) Co-authored-by: Josh Greenslade <joshua.greenslade@onyxinsight.com> Co-authored-by: SlamBamActionman <slambamactionman@gmail.com> * Remove Staff of Entrance from Magic Event Spell (#114) * fix atmosphere system protoman * Revert "Update README.md with new links. (DeltaV-Station#2)" This reverts commit dffabf7. * Revert "Switch RT submodule to new repo (DeltaV-Station#19)" This reverts commit 1000a7b. * Revert "Add section to link to space-wizards PR URL to PR template (#143)" This reverts commit 48201fc. --------- Co-authored-by: Rem <GitRem@grifton.lol> Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> Co-authored-by: riccardi48 <39341154+riccardi48@users.noreply.github.com> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: Jessica M <jessica@jessicamaybe.com> Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> Co-authored-by: Minerva <218184747+mnva0@users.noreply.github.com> Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com> Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: Kyle Tyo <akikai297@gmail.com> Co-authored-by: Connor Huffine <chuffine@gmail.com> Co-authored-by: portfiend <109661617+portfiend@users.noreply.github.com> Co-authored-by: rumaks <me@rumaks.xyz> Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com> Co-authored-by: āda <ss.adasts@gmail.com> Co-authored-by: iaada <iaada@users.noreply.github.com> Co-authored-by: ThatGuyUSA <thatguyusa123@gmail.com> Co-authored-by: InsoPL <lukasz.lindert@protonmail.com> Co-authored-by: AndrewFenriz <78079974+AndrewFenriz@users.noreply.github.com> Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com> Co-authored-by: Vladislav Suchkov <20380250+murolem@users.noreply.github.com> Co-authored-by: korczoczek <danielkorczok@gmail.com> Co-authored-by: B_Kirill <153602297+B-Kirill@users.noreply.github.com> Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> Co-authored-by: JoshGreenslade <joshgreenslade@gmail.com> Co-authored-by: Josh Greenslade <joshua.greenslade@onyxinsight.com> Co-authored-by: SlamBamActionman <slambamactionman@gmail.com> Co-authored-by: Rami <ramialanbagy@gmail.com>

avaaaali

d531853

sowelipililimute requested a review from a team as a code owner August 3, 2026 22:45

github-actions Bot added S: Untriaged S: Needs Review Changes: Sprites Changes: Audio size/L and removed S: Untriaged S: Needs Review labels Aug 3, 2026

ShepardToTheStars reviewed Aug 10, 2026

View reviewed changes

ShepardToTheStars added the Changes Requested By Maintainer label Aug 13, 2026

StarboundSolaris pushed a commit to StarboundSolaris/Solaris-Turbo-Touhou-Skibidi-Turbo-Bullshit-Development-Repo-Of-Doom-And-Despair that referenced this pull request Aug 14, 2026

Microoptimize Vector2i.Offset (DeltaV-Station#103)

418be47

* microopt offset works on my machine award * tweaks

Navigation Menu

Uh oh!

avaaaali - #103

avaaaali#103
sowelipililimute wants to merge 1 commit into
DeltaV-Station:masterfrom
sowelipililimute:work/densetsu/avali

sowelipililimute commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

ShepardToTheStars left a comment

Uh oh!

ShepardToTheStars Aug 10, 2026

Uh oh!

ShepardToTheStars Aug 10, 2026

Uh oh!

ShepardToTheStars Aug 10, 2026

Uh oh!

ShepardToTheStars Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	comp.CurrentFeathers += 1;
	comp.CurrentFeathers = Math.Min(comp.CurrentFeathers + 1, comp.MaximumFeathers);

Uh oh!

Conversation

sowelipililimute commented Aug 3, 2026

About the PR

Technical details

Test plan

Requirements

Licensing

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

ShepardToTheStars left a comment

Choose a reason for hiding this comment

Uh oh!

ShepardToTheStars Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

ShepardToTheStars Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

ShepardToTheStars Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

ShepardToTheStars Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants