Separate microphone and speaker toggles for handheld radios. - #110
Open
och-och wants to merge 1 commit into
Open
Separate microphone and speaker toggles for handheld radios.#110och-och wants to merge 1 commit into
och-och wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Handheld radio (including security radio) have separate actions for toggling microphone and speaker: primary interact for microphone, alt-interact for speaker. Both options also have right-click menu verbs.
Semi-side effect is that intercoms also get toggles in the right-click menu.
Why / Balance
Being forced to broadcast yourself when you just want to listen is not fun, so there should be a way to turn off microphone while receiving.
Technical details
Test plan
Spawn a couple handhelds, security radio, intercom. Set them to listen and/or broadcast, and say hi 👋.
Examine their examine text correctness, and that verbs correlate to the actions.
Media
Requirements
Licensing
Breaking changes
Changelog
🆑 och