Regridding improvements: support datasets, nodal data, add nearest and inverse distance#369
Draft
Huite wants to merge 14 commits into
Draft
Regridding improvements: support datasets, nodal data, add nearest and inverse distance#369Huite wants to merge 14 commits into
Huite wants to merge 14 commits into
Conversation
added 7 commits
June 11, 2025 17:15
Add Nearest, InverseDistance
added 3 commits
June 20, 2025 15:39
* Simplify StructuredGrid1d linear weights * Expand UnstructuredGrid2d tests * Add facet property to regridding Grids * Avoid singularity in inverse distance weighting
* Remove decreasing y axes in fixtures * Simplify Structured1d: get rid of overlap_1d_structured and locate_inside. * Fix boolean logic in _find_neighbor; 1 and -1 are allowed at source_index 0 and n-1 respectively!
Huite
commented
Jul 7, 2025
| raise ValueError( | ||
| f"source is {source.facet} associated, target is {target.facet} " | ||
| "associated. OverlapRegridder can only regrid face to face, or " | ||
| "node to face." |
Collaborator
Author
There was a problem hiding this comment.
We can refer to the LocatorRegridder here instead for face -> node.
Actually, just use locate_inside?
Only node -> node should fail? Then point to Nearest or InverseDistance.
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.