fix: clean up dead client connections on SocketException in NioReceiver#113
Open
technosophy wants to merge 1 commit intoDempsy:masterfrom
Open
fix: clean up dead client connections on SocketException in NioReceiver#113technosophy wants to merge 1 commit intoDempsy:masterfrom
technosophy wants to merge 1 commit intoDempsy:masterfrom
Conversation
…er reader loop When a client connection resets (Connection reset SocketException), the IOException was caught by the outer reader loop but the broken channel and selector key were never cleaned up. Over time, dead keys accumulate in the selector, firing readable events every cycle, causing a busy spin that starves the reader thread and effectively stops the service from processing new messages. Fix: catch IOException at the individual Client.read() call site and invoke closeup() to properly cancel the key and close the channel, matching the cleanup behavior already used for EOF and corrupt messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client connection resets (Connection reset SocketException), the IOException was caught by the outer reader loop but the broken channel and selector key were never cleaned up. Over time, dead keys accumulate in the selector, firing readable events every cycle, causing a busy spin that starves the reader thread and effectively stops the service from processing new messages.
Fix: catch IOException at the individual Client.read() call site and invoke closeup() to properly cancel the key and close the channel, matching the cleanup behavior already used for EOF and corrupt messages.