fix(teams): prevent concurrent slug collision with sequential retry (#499)

apps/backend/src/__tests__/slug.test.ts

@@ -0,0 +1,74 @@
+import { describe, it, expect, vi } from 'vitest';
+
+import { createSlug, generateUniqueSlug } from '../utils/slug';
+
+describe('createSlug', () => {
+  it('lowercases and trims input', () => {
+    expect(createSlug('  Hello World  ')).toBe('hello-world');
+  });
+
+  it('replaces spaces with hyphens', () => {
+    expect(createSlug('My Team Name')).toBe('my-team-name');
+  });
+
+  it('strips non-alphanumeric characters', () => {
+    expect(createSlug('DevCard @Core!')).toBe('devcard-core');
+  });
+
+  it('collapses multiple hyphens', () => {
+    expect(createSlug('a--b---c')).toBe('a-b-c');
+  });
+
+  it('removes leading and trailing hyphens', () => {
+    expect(createSlug('--team--')).toBe('team');
+  });
+});
+
+describe('generateUniqueSlug', () => {
+  it('returns base slug when it is available', async () => {
+    const slugExists = vi.fn().mockResolvedValue(false);
+    const result = await generateUniqueSlug('My Team', slugExists);
+    expect(result).toBe('my-team');
+    expect(slugExists).toHaveBeenCalledOnce();
+  });
+
+  it('returns sequential numeric suffix when base slug is taken', async () => {
+    const slugExists = vi.fn()
+      .mockResolvedValueOnce(true)  // my-team taken
+      .mockResolvedValueOnce(false); // my-team-1 free
+    const result = await generateUniqueSlug('My Team', slugExists);
+    expect(result).toBe('my-team-1');
+  });
+
+  it('increments suffix deterministically until a free slot is found', async () => {
+    const slugExists = vi.fn()
+      .mockResolvedValueOnce(true)  // my-team
+      .mockResolvedValueOnce(true)  // my-team-1
+      .mockResolvedValueOnce(true)  // my-team-2
+      .mockResolvedValueOnce(false); // my-team-3 free
+    const result = await generateUniqueSlug('My Team', slugExists);
+    expect(result).toBe('my-team-3');
+  });
+
+  it('throws when all 10 suffix candidates are taken', async () => {
+    const slugExists = vi.fn().mockResolvedValue(true);
+    await expect(generateUniqueSlug('My Team', slugExists)).rejects.toThrow(
+      'Unable to generate unique slug',
+    );
+    expect(slugExists).toHaveBeenCalledTimes(11); // base + 10 suffixes
+  });
+
+  it('produces consistent slugs across concurrent calls for different inputs', async () => {
+    const takenSlugs = new Set<string>();
+    const slugExists = vi.fn(async (slug: string) => takenSlugs.has(slug));
+
+    const [a, b] = await Promise.all([
+      generateUniqueSlug('Alpha Team', slugExists),
+      generateUniqueSlug('Beta Team', slugExists),
+    ]);
+
+    expect(a).toBe('alpha-team');
+    expect(b).toBe('beta-team');
+    expect(a).not.toBe(b);
+  });
+});

apps/backend/src/__tests__/team.test.ts

@@ -1,8 +1,12 @@
+import { Prisma, TeamRole } from '@prisma/client';
+import Fastify from 'fastify';
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-import Fastify, { FastifyInstance } from 'fastify';
-import { PrismaClient, TeamRole } from '@prisma/client';
+
 import { teamRoutes } from '../routes/team';
 
+import type { PrismaClient } from '@prisma/client';
+import type { FastifyInstance } from 'fastify';
+
 // ─── Shared mock data ─────────────────────────────────────────────────────────
 
 const MOCK_OWNER_ID    = 'user-uuid-001';
@@ -92,7 +96,7 @@ const prismaMock = {
 
 // ─── App factory ──────────────────────────────────────────────────────────────
 
-let mockJwtVerify = vi.fn();
+const mockJwtVerify = vi.fn();
 
 async function buildApp(): Promise<FastifyInstance> {
   const app = Fastify({ logger: false });
@@ -118,7 +122,7 @@ async function createTeam(
   app: FastifyInstance,
   body: Record<string, unknown>,
   authenticated = true,
-) {
+): Promise<ReturnType<typeof app.inject>> {
   return app.inject({
     method: 'POST',
     url: '/',
@@ -220,6 +224,46 @@ describe('Teams API', () => {
       expect(res.statusCode).toBe(500);
       expect(res.json()).toMatchObject({ error: 'Failed to create team' });
     });
+
+    it('201 — retries and succeeds when first attempt loses slug race to concurrent request', async () => {
+      // First generateUniqueSlug: base slug appears available
+      prismaMock.team.findUnique.mockResolvedValueOnce(null);
+      // First $transaction: P2002 — another request inserted first
+      prismaMock.$transaction.mockRejectedValueOnce(
+        new Prisma.PrismaClientKnownRequestError('Unique constraint failed', { code: 'P2002', clientVersion: '0' }),
+      );
+      // Second generateUniqueSlug: base slug now taken, devcard-core-1 is free
+      prismaMock.team.findUnique.mockResolvedValueOnce(MOCK_TEAM); // devcard-core taken
+      prismaMock.team.findUnique.mockResolvedValueOnce(null);      // devcard-core-1 free
+      // Second $transaction: succeeds with suffix slug
+      prismaMock.$transaction.mockImplementationOnce(async (cb: any) => {
+        return cb({
+          team: { create: vi.fn().mockResolvedValue({ ...MOCK_TEAM, slug: 'devcard-core-1' }) },
+          teamMember: { create: vi.fn().mockResolvedValue({}) },
+        });
+      });
+
+      const res = await createTeam(app, validBody);
+
+      expect(res.statusCode).toBe(201);
+      expect(res.json().slug).toBe('devcard-core-1');
+    });
+
+    it('409 — exhausts all retry attempts when DB rejects every slug with P2002', async () => {
+      const p2002 = new Prisma.PrismaClientKnownRequestError(
+        'Unique constraint failed on the fields: (`slug`)',
+        { code: 'P2002', clientVersion: '0' },
+      );
+      // Slug always appears available at the application level
+      prismaMock.team.findUnique.mockResolvedValue(null);
+      // DB always rejects with P2002 (concurrent inserts won every race)
+      prismaMock.$transaction.mockRejectedValue(p2002);
+
+      const res = await createTeam(app, validBody);
+
+      expect(res.statusCode).toBe(409);
+      expect(prismaMock.$transaction).toHaveBeenCalledTimes(5);
+    });
   });
 
   // ── GET /:slug — public team profile ─────────────────────────────────────