fix(web): distinguish 404 errors from network/server failures#605
Open
IshitaMittal29 wants to merge 1 commit into
Open
fix(web): distinguish 404 errors from network/server failures#605IshitaMittal29 wants to merge 1 commit into
IshitaMittal29 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc:approved
|
Hi @IshitaMittal29, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@ShantKhatri has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — All Checks PassedBackend — SKIP
Mobile — SKIP
Web — PASS
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where Profile and Card pages displayed "not found" messages for all API failures, including network and server errors.
Closes #603
Type of Change
What Changed
ApiError.How to Test
/u/test) or card (/devcard/test) page.Checklist
Screenshots
Additional Context
Previously, all API failures were treated as "not found" responses. This change distinguishes genuine 404 responses from network/server failures, providing more accurate feedback to users.