refactor(auth): replace any-cast authenticate fallback with typed pre…#608
refactor(auth): replace any-cast authenticate fallback with typed pre…#608yachikadev wants to merge 2 commits into
Conversation
…Handler - Remove (app as any).authenticate fallback chains in cards.ts, connect.ts, event.ts, nfc.ts - Use preHandler: [(req, reply) => app.authenticate(req, reply)] consistently - Fix TS generic types on route methods to resolve tsc errors Closes Dev-Card#554
|
@yachikadev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
backend
gssoc:approved
|
Hi @yachikadev, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>
CI — Checks FailedBackend — FAIL
Mobile — SKIP
Web — SKIP
Last updated: |
|
@Harxhit, |
|
@yachikadev Please fix merge conflicts. |
|
Facing some git issues with this PR, closing and reopening a fresh one. #626 |
2 participants
Summary
Replaces all
(app as any).authenticatefallback chains with properlytyped
preHandler— same pattern established in forteam.ts.Changes
cards.ts— auth cleanupconnect.ts— auth cleanupevent.ts— auth cleanup + fixed TS generic types on route methodsnfc.ts— auth cleanup + removed unused importsTest Results
tsc --noEmit— 0 errorseslint— 0 errors, 0 warningsCloses #594