fix(events): add missing organizerId to response and fix incomplete test mocks causing 500 crashes#609
Closed
yachikadev wants to merge 3 commits into
Closed
fix(events): add missing organizerId to response and fix incomplete test mocks causing 500 crashes#609yachikadev wants to merge 3 commits into
yachikadev wants to merge 3 commits into
Conversation
…Handler - Remove (app as any).authenticate fallback chains in cards.ts, connect.ts, event.ts, nfc.ts - Use preHandler: [(req, reply) => app.authenticate(req, reply)] consistently - Fix TS generic types on route methods to resolve tsc errors Closes Dev-Card#554
…e and fix incomplete test mocks - Add organizerId field to EventDetails type and response object in event.ts - Uncomment organizerId assertion in event.test.ts - Add organizer object to GET /api/events/:slug mocks - Add _count object to GET /api/events/:slug/attendees mocks (was causing 500 crashes in 6 tests) Closes Dev-Card#606
|
@yachikadev is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @yachikadev, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
github-actions
Bot
added
backend
gssoc:approved
Signed-off-by: Yachika Sharma <shakuntalaramphalsharma@gmail.com>
CI — Checks FailedBackend — FAIL
Mobile — SKIP
Web — SKIP
Last updated: |
Contributor
Author
|
ing some git issues with this PR, closing and reopening a fresh one #632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two pre-existing bugs found while working on #554.
Confirmed via
git stashthat both issues predate any auth-cleanup changes.Changes
event.ts— added missingorganizerIdtoGET /api/events/:slugresponseevent.test.ts— fixed incomplete mocks:organizer: { username, displayName }to slug route mocks_count: { attendees: N }to attendees route mocks (was causing 500 crashes in 6 tests)Test Results
tsc --noEmit— 0 errorseslint— 0 errors, 0 warningsCloses #606