refactor: standardize ESM import paths and optimize shared package en…#634
Conversation
|
@ShantKhatri is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
backend
gssoc:approved
|
Hi @ShantKhatri, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — SKIP
Last updated: |
ShantKhatri
force-pushed
the
uat-rollout-fixes
branch
from
a023d99 to
69c568c
Compare
|
Hi @Harxhit , Could you please approve these changes? |
If we merge this PR it will introduce typecheck issues. |
Thanks for flagging that. I have fixed it now. Changes here should go as rebase and merge, as commits here are specific one. |
|
|
||
| import type { CardResponse, UpdateCardBody, UpdatedCardResponse } from '../services/cardService'; | ||
| import type { Card } from '@devcard/shared/src/types.js'; | ||
| import type { Card } from '@devcard/shared'; |
There was a problem hiding this comment.
This is causing typecheck error
| @@ -1,4 +1,4 @@ | |||
| import { getPlatform } from '@devcard/shared/src/platforms'; | |||
| import { getPlatform } from '@devcard/shared'; | |||
There was a problem hiding this comment.
It's not visible in checks.
Approved |
2 participants
No description provided.