fix(mobile): request camera permission on iOS to avoid blank screen#637
Open
Nareshkumawat-star wants to merge 1 commit into
Open
fix(mobile): request camera permission on iOS to avoid blank screen#637Nareshkumawat-star wants to merge 1 commit into
Nareshkumawat-star wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@blankirigaya has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
CI — All Checks PassedBackend — SKIP
Mobile — PASS
Web — SKIP
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the iOS camera permission handling issue in the mobile QR scanner screen. Previously, when the camera permission status was undetermined (
-1), the screen assumed permission was granted and mounted the nativeCameracomponent. If the user subsequently denied permission in the iOS system dialog, the scanner area stayed blank without showing any error feedback or prompt to re-enable permissions in settings.With this change, permission is requested programmatically first. If denied, the UI correctly transitions to a placeholder screen with a button that triggers a settings redirect dialog.
Closes : #610
Type of Change
What Changed
apps/mobile/src/screens/ScanScreen.tsx:Linking,AppState,AppStateStatus, andNativeModulesfromreact-native.checkInitialCameraPermissionfunction to check status and prompt for authorization programmatically usingRNCameraKitModuleif status is undetermined (-1).requestCameraPermissionto show a user-friendly alert on iOS if permissions are denied, with a redirect link directly to iOS App Settings.AppStatelistener to automatically re-evaluate camera permission status when the user returns to the app from iOS Settings.errvariable inhandleSaveQR.How to Test
Checklist
npm run lintpasses).npm run typecheck --workspaces --if-present).npm run test --workspaces --if-present).console.logor debug statements left in the code.