Skip to content

fix(ui): modal bottom clipping/overflow on finance modals #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dev869 merged 1 commit into from
May 19, 2026
Merged

fix(ui): modal bottom clipping/overflow on finance modals #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/components/common/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ export function Modal({
ref={contentRef}
tabIndex={-1}
className={cn(
'relative z-10 flex flex-col bg-[var(--bg-card)] outline-none overflow-hidden',
'w-full h-full md:h-auto md:max-h-[88vh]',
'relative z-10 flex flex-col bg-[var(--bg-card)] outline-none overflow-hidden box-border',
'w-full h-[100dvh] max-h-[100dvh] md:h-auto md:max-h-[88vh]',
'md:w-full md:rounded-2xl md:border md:border-[var(--border)]',
'md:shadow-[0_24px_60px_-12px_rgba(0,0,0,0.45)]',
'animate-fade-in-up md:animate-scale-in',
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/finance/AddIncomeModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ export function AddIncomeModal({ onClose, onAdded }: AddIncomeModalProps) {
aria-modal="true"
aria-label="Add income"
className={cn(
'fixed z-[60] flex flex-col bg-[var(--bg-page)]',
'inset-0',
'fixed z-[60] flex flex-col bg-[var(--bg-page)] box-border overflow-hidden',
'inset-0 max-h-[100dvh]',
'md:inset-auto md:top-1/2 md:left-1/2 md:-translate-x-1/2 md:-translate-y-1/2',
'md:w-full md:max-w-md md:max-h-[85vh] md:rounded-2xl md:border md:border-[var(--border)] md:shadow-2xl',
'animate-fade-in-up md:animate-scale-in'
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/finance/NewInvoiceModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ export function NewInvoiceModal({ clients, workItems, settings, hourlyRate, paym
{/* Modal — full page on mobile, centered card on desktop */}
<div
className={cn(
'fixed z-[60] flex flex-col bg-[var(--bg-page)]',
'fixed z-[60] flex flex-col bg-[var(--bg-page)] box-border overflow-hidden',
// Mobile: full page
'inset-0',
'inset-0 max-h-[100dvh]',
// Desktop: centered card
'md:inset-auto md:top-1/2 md:left-1/2 md:-translate-x-1/2 md:-translate-y-1/2',
'md:w-full md:max-w-lg md:max-h-[85vh] md:rounded-2xl md:border md:border-[var(--border)] md:shadow-2xl',
Expand Down
Loading