Feature/improve file limit warning 228#301
Open
stephenOwino wants to merge 3 commits intoDevinoSolutions:devfrom
Open
Feature/improve file limit warning 228#301stephenOwino wants to merge 3 commits intoDevinoSolutions:devfrom
stephenOwino wants to merge 3 commits intoDevinoSolutions:devfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
bcef460 to
eb1c786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228
This PR improves the user experience when the file upload limit is exceeded by
Changes Made
Added WarningAlert.tsx New component that displays warning messages
Modified useRootProvider.ts.
RootContext.ts: AddedwarningMessageandclearWarningto context interfaceMainBox.tsx: IntegratedWarningAlertcomponent to display warningsBefore
Extra files were silently ignored with no visible feedback to users
After
Users see a clear warning: eg."You selected 43 files. Only 10 were added. 33 files ignored." with the ability to dismiss it manually or automatically when upload begins.