Replace icon export workflow and add exact WinGet icon fallback#4522
Merged
Marc-André Moreau (mamoreau-devolutions) merged 3 commits intomainfrom Mar 24, 2026
Merged
Conversation
Benoît Cortier (CBenoit)
approved these changes
Mar 24, 2026
5f4c065
into
main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
There were a few issues with the previous generation - trailing \n characters, but also trailing spaces. I noticed there are 114 package names truncated in the original excel file with "..." ellipsis, those will be fixed separately, as we need to recover the full package names.
For #4509 - I fixed the trailing \n character in the existing Python.Launcher entry, but the current UniGetUI code checks for "Winget.VendorName.PackageName" and then "PackageName", which is why it only looks for "Launcher". I updated the code to check for "Winget.VendorName.PackageName", then "VendorName.PackageName, and then "PackageName". Only 40 entries are prefixed with Winget currently, so I'll look into better ways to handle exact package id entries.