Fix WorkerPool empty URL list hang - #9
Open
mdipanjan wants to merge 1 commit into
Open
Conversation
mdipanjan
marked this pull request as ready for review
May 8, 2026 02:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
WorkerPool.pullAll([])so it resolves immediately when there are no URLs to process.Previously, an empty URL list created a Promise but dispatched no workers. Since no worker messages could arrive, the Promise never resolved and callers could hang indefinitely.
Change
WorkerPool.pullAllurls.length === 0Validation
Verified locally that WorkerPool.pullAll([]) now resolves instead of timing out.