Skip to content

Make debugger fail gracefully on non-ASCII word separators #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dstelzer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make debugger fail gracefully on non-ASCII word separators #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab8e03
make debugger report non-ASCII word separators
dstelzer Sep 16, 2026
7d935cb
don't report errors until the terminal is set up
dstelzer Sep 16, 2026
87175fa
readme
dstelzer Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ Release notes:

Compiler: improved dictionary word matching accuracy.

Compiler: Improved ordering of strings in WRIT chunk, which
Compiler: improved ordering of strings in WRIT chunk, which
improves performance on slow platforms like 6502.

Debugger: fails more gracefully when given non-ASCII word
separators.

1c/03, Lib 1.2.4:

Language: CSS text-decoration: reverse has been replaced with
Expand Down
10 changes: 8 additions & 2 deletions src/debugger.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,13 +1445,13 @@ int debugger(int argc, char **argv) {
} else if(!strcmp(optarg, "none")) {
output_config.formatting = FORMAT_NEVER;
} else {
fprintf(stderr, "Unrecognized formatting style \"%s\"; valid styles are \"default\", \"ansi\", or \"none\"\n", optarg);
fprintf(stderr, "Error: Unrecognized formatting style \"%s\"; valid styles are \"default\", \"ansi\", or \"none\"\n", optarg);
return 1;
}
break;
default:
if(opt >= 0) {
fprintf(stderr, "Unimplemented option '%c'\n", opt);
fprintf(stderr, "Error: Unimplemented option '%c'\n", opt);
return 1;
}
break;
Expand Down Expand Up @@ -1488,6 +1488,12 @@ int debugger(int argc, char **argv) {
}

if(wordseps) {
for(i = 0; wordseps[i]; i++) { // We can't handle them yet, but we can at least fail gracefully
if(wordseps[i] > 0x7f) {
report(LVL_ERR, 0, "The debugger does not currently support non-ASCII --word-seps");
exit(1);
}
}
prepare_wordseps(wordseps);
free(wordseps);
} else {
Expand Down
Binary file removed src/dgdebug.wasm
View file
Open in desktop
Binary file not shown.
Loading