Use mock module and move tests#47
Conversation
|
Ideally the tests would be separate from the main module(s) so that they wouldn't be present in the application. Due to these complications maybe it is easier to move the tests as you have done but I might ask for a second opinion. I think it might also be good to wait until we can get the CI running again (#46) to verify the tests can still all run as expected. |
|
@isikhar do you have any objections to this being merged? I would still like to check that we can still run the tests before merging. |
|
We should merge #46 first, then fix-up this so that the tests pass. |
|
@joeshannon and @isikhar, this ok? |
joeshannon
left a comment
There was a problem hiding this comment.
Looks good to me. I think Irakli was previously happy with these changes.
|
These changes are fine with me as well. |
|
Is the CI known to be broken? |
|
No I don't think so. Not sure why it's not running. I see that it run for your fork. I'm not hugely familiar with GH actions, we currently have Does that seem correct? |
|
So it did (see https://github.com/DominicOram/diffcalc/actions/runs/3338486618/jobs/5526204223). Yes, those actions seem correct to me. Are we happy to chalk it up to GH weirdness and get I'll merge this? |
Fixes #45
To test:
mockandtestbeing moved out of top level