Murko: continue thaw if redis is down #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob720
changed the title
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1750 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 282 282
Lines 10686 10698 +12
=======================================
+ Hits 10592 10604 +12
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacob720
force-pushed
the
mx_bluesky_810_continue_thaw_if_redis_is_down
branch
from
762bea8 to
a6493aa
Compare
DominicOram
requested changes
Dec 19, 2025
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, Just the one comment
Comment on lines
125
to
127
| self._x_mm_setter(0) | ||
| self._y_mm_setter(0) | ||
| self._z_mm_setter(0) |
Contributor
There was a problem hiding this comment.
Should: I think we probably want to set all these to 0 even if redis is down. Otherwise when redis goes down we will end up centring by the last amount we got, which is probably wrong
| await murko_results.stage() | ||
| await murko_results.trigger() | ||
| await murko_results.unstage() | ||
| assert await murko_results.x_mm.get_value() == 0 |
Contributor
There was a problem hiding this comment.
Should: See comment above. Either this test or another should confirm that if we set some rubbish values into the x/y/z before stage it will reset them
DominicOram
deleted the
mx_bluesky_810_continue_thaw_if_redis_is_down
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/mx-bluesky#810
Required by DiamondLightSource/mx-bluesky#1437
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}