Conversation
|
@yousefmoazzam I've got few test failures (6) in this branch that are related to the output filename changes. Specifically the error is: Have you seen this one? I reckon it counts the lock file being temporarily there. |
I have indeed seen this when running tests locally, but not in recent CI jobs. If CI were to also report the error then I'd be inclined to think that a dependency's version has been updated which breaks things, but that isn't the case. So unfortunately I'm not yet sure what to make of it. |
yousefmoazzam
left a comment
There was a problem hiding this comment.
Just one comment for now about clarifying types, will keep looking
yousefmoazzam
left a comment
There was a problem hiding this comment.
Looks good overall, a few comments about making the new test a bit clearer, and some bits about docs.
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Co-authored-by: Yousef Moazzam <yousefmoazzam@users.noreply.github.com>
Enables reusing flats/darks coming from a different scan by providing an additional
image_key_pathparameter.Checklist