Skip to content

remove intermediate dataset saving from data_checker with --save-all #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkazanc merged 1 commit into from
Apr 14, 2026
Merged

remove intermediate dataset saving from data_checker with --save-all #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httomo/transform_layer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def insert_save_methods(self, pipeline: Pipeline) -> Pipeline:
methods.append(m)
if (
(m.save_result or self._save_all)
and m.method_name != "save_to_images"
and m.method_name not in ["save_to_images", "data_checker"]
and "center" not in m.method_name
):
methods.append(
Expand Down
4 changes: 2 additions & 2 deletions tests/test_transform_layer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def test_insert_save_methods_save_all(mocker: MockerFixture, tmp_path: Path):
assert pipeline[3].task_id == "save_t2"


@pytest.mark.parametrize("method_name", ["save_to_images", "find_center_vo"])
def test_insert_save_methods_does_not_save_for_save_to_images(
@pytest.mark.parametrize("method_name", ["save_to_images", "find_center_vo", "data_checker"])
def test_insert_save_methods_does_not_save_for_some_methods(
mocker: MockerFixture, method_name: str, tmp_path: Path
):
comm = MPI.COMM_SELF
Expand Down
Loading