Skip to content

Stamps Frontend#1517

Merged
Difegue merged 11 commits into
Difegue:devfrom
EfronC:feature/stamps-frontend
May 19, 2026
Merged

Stamps Frontend#1517
Difegue merged 11 commits into
Difegue:devfrom
EfronC:feature/stamps-frontend

Conversation

@EfronC
Copy link
Copy Markdown
Contributor

@EfronC EfronC commented Apr 8, 2026

Just moved the Frontend code from #1493 to here. Will leave it as a draft until the other one merges.

Comment thread lib/LANraragi/Model/Stamp.pm Outdated
@EfronC
Copy link
Copy Markdown
Contributor Author

EfronC commented May 3, 2026

For the pagenumber that we use for the id STAMPS_<pagenumber>_<ts>, Should it match Reader.currentPage, or the number shown here(Which is Reader.currentPage+1)?
image

@EfronC EfronC force-pushed the feature/stamps-frontend branch from 03694f5 to ebbd058 Compare May 5, 2026 04:05
@EfronC EfronC force-pushed the feature/stamps-frontend branch from 0212946 to 17d290b Compare May 7, 2026 01:41
@EfronC EfronC marked this pull request as ready for review May 7, 2026 01:41
@EfronC EfronC force-pushed the feature/stamps-frontend branch from 17d290b to 19ee24c Compare May 7, 2026 15:26
Copy link
Copy Markdown
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this a little bit so this is mostly usability concerns atm. It's working pretty well already though 👍

Comment thread public/js/reader.js
Comment thread locales/template/en.po Outdated
Comment thread public/css/lrr.css
Comment thread public/js/reader.js
Comment thread public/js/reader.js Outdated
Comment thread public/js/reader.js Outdated
Comment thread templates/reader.html.tt2 Outdated
Comment thread templates/reader.html.tt2 Outdated
@EfronC EfronC force-pushed the feature/stamps-frontend branch 3 times, most recently from 6942f6c to a2f956e Compare May 11, 2026 23:16
@EfronC EfronC force-pushed the feature/stamps-frontend branch from a2f956e to 5d0d142 Compare May 16, 2026 02:09
Comment thread public/js/reader.js Outdated
Comment thread public/js/reader.js Outdated
Comment thread public/js/reader.js Outdated
Comment thread templates/reader.html.tt2 Outdated
Comment thread templates/reader.html.tt2 Outdated
Comment thread public/js/reader.js Outdated
@EfronC EfronC force-pushed the feature/stamps-frontend branch from a17ffbd to e2ae437 Compare May 17, 2026 23:47
Copy link
Copy Markdown
Owner

@Difegue Difegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! Thanks for all the work thats been put in this.

@Difegue Difegue merged commit cc796bb into Difegue:dev May 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] O-Counter / Nut-Button

3 participants