fix: remove all 20 @ts-nocheck suppressions, fix TypeScript errors properly#22
Open
DigitalBlueprint239 wants to merge 1 commit into
Open
fix: remove all 20 @ts-nocheck suppressions, fix TypeScript errors properly#22DigitalBlueprint239 wants to merge 1 commit into
DigitalBlueprint239 wants to merge 1 commit into
Conversation
…operly Remove @ts-nocheck from all active application files and fix the underlying TypeScript errors with proper null guards and type annotations: - firestore.ts: Add getDb() null guard, type db/auth as nullable, fix all Firestore API calls with null checks - useAuth.tsx: Add getAuth_() null guard for Firebase Auth calls - useFirestore.ts: Fix recursive updatePlay shadowing bug - TeamContext.tsx: Add getDb()/requireCurrentUser() helpers - SmartPlaybook.tsx: Add full type definitions, type all callbacks, fix dead-code mode comparison bug - CanvasArea.tsx: Fix broken import path, type props properly - TouchOptimizedPlaybook.tsx: Fix GameContext fields, type callbacks Create .d.ts declarations for 11 JS components used by TypeScript files. Exclude 13 legacy orphaned files via tsconfig.json exclude array. Fix VITE_ env var regression in react-app-env.d.ts (CRA uses REACT_APP_). Fix NEXT_PUBLIC_ env vars in firebase.ts to REACT_APP_. Update MASTER_TRACKER.md with session log and HIGH-006 resolution. https://claude.ai/code/session_01YZvHkyUzRoa7fd1FfMm5dq
❌ Deploy Preview for magical-starlight-0c1207 failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove @ts-nocheck from all active application files and fix the
underlying TypeScript errors with proper null guards and type annotations:
fix all Firestore API calls with null checks
fix dead-code mode comparison bug
Create .d.ts declarations for 11 JS components used by TypeScript files.
Exclude 13 legacy orphaned files via tsconfig.json exclude array.
Fix VITE_ env var regression in react-app-env.d.ts (CRA uses REACT_APP_).
Fix NEXT_PUBLIC_ env vars in firebase.ts to REACT_APP_.
Update MASTER_TRACKER.md with session log and HIGH-006 resolution.
https://claude.ai/code/session_01YZvHkyUzRoa7fd1FfMm5dq