Repository navigation
docs(specs): Shakedex selling stage — expiry guard, restore a lock by name, delivery plan - #82
Merged
Merged
Conversation
… name, delivery plan
Adds R31 (Lock and Finalize & sign refused when the name would expire before the FINALIZE into the lock, which renews it; a six-month warning) and R32 (restore a lock by name, upgraded by importing its own listing file), corrects R27 (the listing lasts renewalWindow after that FINALIZE), states the daemon's new contract in R25 ("never signs or broadcasts; publishes listings already signed to LearnHNS Market"), places Sell in NameActionsModal and "My listings" on the Market page (R19), aligns the selling requirements' Enforced and Pinned lines with the code and tests the selling tickets create, rewrites the §5 lock-recovery gap as manual with the address-history scan deferred, and describes the selling delivery as a stack of PRs. ADR 0004 gets a dated amendment saying the same about recovery, its decision unchanged; CONTEXT.md defines Locking, Restored lock and My listings.
…uses R31 now counts only the remaining transfer lockup: the full lockup at Lock, and at Finalize & sign the blocks until the lock TRANSFER may be finalized, since a second full lockup would refuse a FINALIZE that renews the name; the six months are measured from the tip to the expiry end. R32 names what a restore by name refuses and why (expired name, a name still Locking, a lock coin already a TRANSFER, a leftover lock coin), and §5 records the Locking and cancel-awaiting-finalize cases as a gap. CONTEXT.md's Locking no longer says no price is signed, and limits the Cancel-transfer abort to before the FINALIZE into the lock is broadcast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec amendments for the Shakedex selling stage (PR 2), decided before any selling code is written.
What changes
expiry_end <= tip + 1 + remaining lockup + 1 day(R9's margin), where the remaining lockup is the fulltransferLockupat Lock andNameParams::blocks_until_finalizeof the lock TRANSFER at Finalize & sign. Below six months from the tip toexpiry_end, the Lock dialog warns. Grounded in hsd 8.0.0: FINALIZE renews a name (chain.js,ns.setRenewal(height)), TRANSFER does not, so the only expiry risk is the lockup.renewalWindowafter the FINALIZE into the lock, which renews the name.Checks
npx prettier --check .passes.