feat: Implement tab grouping functionality #1719

Tlaster · 2026-01-20T08:25:15Z

Copilot

Pull request overview

This pull request implements tab grouping functionality across all three platforms (iOS, Android, and Desktop), allowing users to organize multiple timeline tabs into named groups with custom icons. This addresses issue #1690.

Changes:

Added GroupConfigScreen to all three platforms (iOS, Android, Desktop) for creating and editing tab groups
Modified TabSettingsScreen across all platforms to support creating, editing, and managing tab groups alongside individual tabs
Added localization strings for group-related UI elements across all platforms

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
iosApp/flare/UI/Screen/TabSettingsScreen.swift	Updated to handle both regular tabs and groups, added menu for choosing between adding tabs or groups
iosApp/flare/UI/Screen/GroupConfigScreen.swift	New screen for configuring tab groups with name, icon, and child tabs
iosApp/flare/UI/Route/Route.swift	Added route case for tab group configuration
iosApp/flare/Localizable.xcstrings	Added localization keys for group functionality
desktopApp/src/main/kotlin/dev/dimension/flare/ui/screen/home/TabSettingScreen.kt	Updated to display menu for adding groups or tabs
desktopApp/src/main/kotlin/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt	New screen implementing group configuration with proper localization
desktopApp/src/main/kotlin/dev/dimension/flare/ui/route/Router.kt	Added routing for group configuration screen
desktopApp/src/main/kotlin/dev/dimension/flare/ui/route/Route.kt	Added route data class for tab group configuration
desktopApp/src/main/composeResources/values/strings.xml	Added complete set of localization strings for group functionality
app/src/main/res/values/strings.xml	Added partial localization strings for group functionality (missing some keys)
app/src/main/java/dev/dimension/flare/ui/screen/settings/TabCustomizeScreen.kt	Added isEditing parameter to highlight currently edited tab
app/src/main/java/dev/dimension/flare/ui/screen/home/TabSettingScreen.kt	Updated to support group editing and added dropdown menu
app/src/main/java/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt	New screen for group configuration with some hardcoded strings
app/src/main/java/dev/dimension/flare/ui/screen/home/HomeEntryBuilder.kt	Added routing entry for group configuration
app/src/main/java/dev/dimension/flare/ui/route/Route.kt	Added route for tab group configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/src/main/res/values/strings.xml

Copilot · 2026-01-20T15:58:51Z

iosApp/flare/UI/Screen/GroupConfigScreen.swift

+        .navigationTitle("Select Icon")
+        .toolbar {
+            ToolbarItem(placement: .cancellationAction) {
+                Button("Cancel") {


The title "Select Icon" and button text "Cancel" are hardcoded strings instead of using localized string keys. These should use localized strings for proper internationalization support.

Suggested change

.navigationTitle("Select Icon")

.toolbar {

ToolbarItem(placement: .cancellationAction) {

Button("Cancel") {

.navigationTitle(NSLocalizedString("Select Icon", comment: "Title for icon selection screen"))

.toolbar {

ToolbarItem(placement: .cancellationAction) {

Button(NSLocalizedString("Cancel", comment: "Cancel icon selection")) {

app/src/main/java/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt

Copilot · 2026-01-20T15:58:52Z

app/src/main/java/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt

+                        subTimelineTabItem = tabs.toList(),
+                        metaData =
+                            TabMetaData(
+                                title = TitleType.Text(name.text.toString().ifEmpty { "Group" }),


The default group name "Group" is hardcoded instead of using a localized string resource. This should use a string resource for consistency with the desktop implementation which uses tab_settings_group_default_name. This hardcoded value will not be translated for non-English users.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Tlaster · 2026-01-21T02:26:04Z

@copilot fix the build by ./gradlew ktlintFormat

Copilot · 2026-01-21T02:26:12Z

@Tlaster I've opened a new pull request, #1722, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Tlaster <8370277+Tlaster@users.noreply.github.com>

Fix ktlint line length violation in GroupConfigScreen.kt

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T02:45:41Z

app/src/main/res/values/strings.xml

+    <string name="tab_settings_edit_group">Edit Group</string>
+    <string name="tab_settings_group_empty">No tabs in this group</string>
+    <string name="tab_settings_group_name_placeholder">Group name</string>
+    <string name="tab_settings_group_default_name">New Group</string>


Inconsistent default group name across platforms. Android uses "New Group" while iOS and desktop use "Group". This inconsistency could confuse users switching between platforms.

Suggested change

<string name="tab_settings_group_default_name">New Group</string>

<string name="tab_settings_group_default_name">Group</string>

Copilot · 2026-01-21T02:45:41Z

app/src/main/java/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt

+                        subTimelineTabItem = tabs.toList(),
+                        metaData =
+                            TabMetaData(
+                                title = TitleType.Text(name.text.toString().ifEmpty { "Group" }),


Missing default group name usage. Unlike the iOS and desktop implementations that use a localized default group name resource, this Android implementation hardcodes "Group". The resource tab_settings_group_default_name should be used here for consistency.

Copilot · 2026-01-21T02:45:41Z

iosApp/flare/UI/Screen/GroupConfigScreen.swift

+                Button("Cancel") {
+                    dismiss()


Hardcoded string "Cancel" should be localized. Use NSLocalizedString or Text("cancel_key") for consistency with the rest of the codebase.

Suggested change

Button("Cancel") {

dismiss()

Button(action: {

dismiss()

}) {

Text("cancel_key")

Copilot · 2026-01-21T02:45:41Z

app/src/main/java/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt

+            initialItem?.metaData?.title?.let {
+                when (it) {
+                    is TitleType.Text -> it.content
+                    is TitleType.Localized -> "" // Or resolve string resource if possible


Comment suggests resolving string resource for TitleType.Localized but the implementation returns an empty string. This could lead to losing the localized title when editing a group with a localized title. Consider implementing the actual resolution or documenting why this is acceptable.

Suggested change

is TitleType.Localized -> "" // Or resolve string resource if possible

is TitleType.Localized -> stringResource(id = it.resId)

Copilot · 2026-01-21T02:45:42Z

desktopApp/src/main/kotlin/dev/dimension/flare/ui/screen/home/GroupConfigScreen.kt

+            initialItem?.metaData?.title?.let {
+                when (it) {
+                    is TitleType.Text -> it.content
+                    is TitleType.Localized -> ""


Same issue as in the Android version: TitleType.Localized returns an empty string which could lose the localized title when editing a group. Consider implementing actual resolution or documenting the reasoning.

Suggested change

is TitleType.Localized -> ""

is TitleType.Localized -> defaultGroupName

Copilot · 2026-01-21T02:45:42Z

iosApp/flare/UI/Screen/GroupConfigScreen.swift

+            }
+            .padding()
+        }
+        .navigationTitle("Select Icon")


Hardcoded string "Select Icon" should be localized. While this string does appear in the Localizable.xcstrings file, it should use NSLocalizedString or similar localization mechanism instead of a hardcoded string for consistency with the rest of the codebase.

Suggested change

.navigationTitle("Select Icon")

.navigationTitle(NSLocalizedString("Select Icon", comment: "Title for the icon picker screen"))

Copilot · 2026-01-21T02:45:42Z

app/src/main/res/values/strings.xml

+    <string name="tab_settings_add_tab">Add Tab</string>
+    <string name="tab_settings_edit_group">Edit Group</string>
+    <string name="tab_settings_group_empty">No tabs in this group</string>
+    <string name="tab_settings_group_name_placeholder">Group name</string>


Inconsistent string capitalization across platforms. Android uses "Group name" (lowercase 'n') while iOS and desktop use "Group Name" (uppercase 'N'). String resources should be consistent across all platforms for the same UI element.

Suggested change

<string name="tab_settings_group_name_placeholder">Group name</string>

<string name="tab_settings_group_name_placeholder">Group Name</string>

Tlaster added 4 commits January 20, 2026 16:24

feat: Implement tab grouping functionality

0af37e1

add group timeline ui for desktop

389adff

fix lint

a40503f

add group timeline ui for ios

82062a0

Tlaster requested a review from Copilot January 20, 2026 15:54

Copilot started reviewing on behalf of Tlaster January 20, 2026 15:55 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Apply suggestions from code review

2a14a13

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

c0dbdea

Copilot AI mentioned this pull request Jan 21, 2026

Fix ktlint line length violation in GroupConfigScreen.kt #1722

Merged

Copilot AI and others added 2 commits January 21, 2026 02:40

Fix ktlint line length violation in GroupConfigScreen.kt

7fb0fe0

Co-authored-by: Tlaster <8370277+Tlaster@users.noreply.github.com>

Merge pull request #1722 from DimensionDev/copilot/sub-pr-1719

c8d4555

Fix ktlint line length violation in GroupConfigScreen.kt

Tlaster requested a review from Copilot January 21, 2026 02:42

Copilot started reviewing on behalf of Tlaster January 21, 2026 02:42 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

Tlaster merged commit 52d8d1c into master Jan 21, 2026
13 checks passed

Tlaster deleted the feature/groupped_timeline branch January 21, 2026 13:55

	<string name="tab_settings_group_default_name">New Group</string>
	<string name="tab_settings_group_default_name">Group</string>

	is TitleType.Localized -> "" // Or resolve string resource if possible
	is TitleType.Localized -> stringResource(id = it.resId)

	is TitleType.Localized -> ""
	is TitleType.Localized -> defaultGroupName

	.navigationTitle("Select Icon")
	.navigationTitle(NSLocalizedString("Select Icon", comment: "Title for the icon picker screen"))

	<string name="tab_settings_group_name_placeholder">Group name</string>
	<string name="tab_settings_group_name_placeholder">Group Name</string>

feat: Implement tab grouping functionality #1719

feat: Implement tab grouping functionality #1719

Uh oh!

Conversation

Tlaster commented Jan 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Tlaster commented Jan 21, 2026

Uh oh!

Copilot AI commented Jan 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants