refactor(core): centralize Stellar address strkey (closes #148)

packages/core/src/contracts/resolve-method-args.ts

@@ -2,8 +2,7 @@ import { CaatingaError, CaatingaErrorCode } from "../errors/CaatingaError.js";
 import { formatNamedCliArgs } from "./format-cli-args.js";
 import { resolveSourceAddress } from "./resolve-source-address.js";
 import type { DeployArgValue } from "./resolve-deploy-args.js";
-
-const STELLAR_ADDRESS_REGEX = /^G[A-Z2-7]{55}$/;
+import { STELLAR_ADDRESS_REGEX } from "../stellar-cli/strkey.js";
 
 export type ResolveMethodArgsOptions = {
   args: Record<string, DeployArgValue>;

packages/core/src/contracts/resolve-source-address.ts

@@ -2,8 +2,7 @@ import { CaatingaError, CaatingaErrorCode } from "../errors/CaatingaError.js";
 import { checkBinary } from "../shell/check-binary.js";
 import { runCommand } from "../shell/run-command.js";
 import { assertSafeSourceAccount } from "./source-account.js";
-
-const STELLAR_ADDRESS_REGEX = /^G[A-Z2-7]{55}$/;
+import { STELLAR_ADDRESS_REGEX } from "../stellar-cli/strkey.js";
 
 export async function resolveSourceAddress(options: {
   source: string;

packages/core/src/contracts/validate-source-shape.ts

@@ -1,5 +1,5 @@
 import { CaatingaError, CaatingaErrorCode } from "../errors/CaatingaError.js";
-import { isLikelyPublicKeySource } from "../stellar-cli/recover-deploy-contract-id.js";
+import { isLikelyPublicKeySource } from "../stellar-cli/strkey.js";
 
 export function validateSourceShape(source: string): CaatingaError | undefined {
   if (source.startsWith("S")) {

packages/core/src/stellar-cli/recover-deploy-contract-id.ts

@@ -24,9 +24,9 @@ type HorizonOperationsResponse = {
   };
 };
 
-export function isLikelyPublicKeySource(source: string): boolean {
-  return /^G[A-Z2-7]{55}$/.test(source);
-}
+// Re-exported from the shared strkey module (#148); kept here for back-compat
+// with existing importers of this path.
+export { isLikelyPublicKeySource } from "./strkey.js";
 
 export function decimalSaltToHex(salt: string): string {
   return BigInt(salt).toString(16).padStart(64, "0");

packages/core/src/stellar-cli/strkey.test.ts

@@ -0,0 +1,19 @@
+import { describe, expect, it } from "vitest";
+import { STELLAR_ADDRESS_REGEX, isLikelyPublicKeySource } from "./strkey.js";
+
+describe("strkey", () => {
+  const validKey = "GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF";
+
+  it("should_match_a_valid_public_key", () => {
+    expect(STELLAR_ADDRESS_REGEX.test(validKey)).toBe(true);
+    expect(isLikelyPublicKeySource(validKey)).toBe(true);
+  });
+
+  it("should_reject_named_aliases_and_malformed_keys", () => {
+    expect(isLikelyPublicKeySource("alice")).toBe(false);
+    expect(isLikelyPublicKeySource(validKey.slice(0, -1))).toBe(false); // too short
+    expect(isLikelyPublicKeySource(`${validKey}A`)).toBe(false); // too long
+    expect(isLikelyPublicKeySource(validKey.replace("G", "M"))).toBe(false); // wrong version byte
+    expect(isLikelyPublicKeySource(validKey.replace(/.$/, "1"))).toBe(false); // 1 not in base32 alphabet
+  });
+});

packages/core/src/stellar-cli/strkey.ts

@@ -0,0 +1,13 @@
+// Single source of truth for the Stellar account (public-key) strkey shape.
+// Previously this regex was copy-pasted in three places (resolve-method-args,
+// resolve-source-address, recover-deploy-contract-id) and source validation
+// reached into the deploy-recovery module just to borrow it (#148). Centralizing
+// it here removes the divergence risk and the cross-module coupling.
+
+/** Stellar account (public-key) strkey: `G` followed by 55 base32 `[A-Z2-7]` chars. */
+export const STELLAR_ADDRESS_REGEX = /^G[A-Z2-7]{55}$/;
+
+/** True when `source` is a raw Stellar public key rather than a named alias. */
+export function isLikelyPublicKeySource(source: string): boolean {
+  return STELLAR_ADDRESS_REGEX.test(source);
+}