Skip to content

fix(core): upgrade skip path returns artifacts file path, not cwd (#85) #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Galmanus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): upgrade skip path returns artifacts file path, not cwd (#85) #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/contracts/upgrade-contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ describe("upgradeContractInPlace", () => {
});

expect(result.skipped).toBe(true);
// #85: the skip path must return the artifacts file path, not cwd.
expect(result.artifactPath).toBe(path.join(tmpDir, "caatinga.artifacts.json"));
const uploadCalls = runCommand.mock.calls.filter(([, args]) => args[1] === "upload");
const invokeCalls = runCommand.mock.calls.filter(([, args]) => args[1] === "invoke");
expect(uploadCalls).toHaveLength(0);
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/contracts/upgrade-contract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import path from "node:path";
import { withArtifactsLock } from "../artifacts/artifacts-lock.js";
import { readArtifacts } from "../artifacts/read-artifacts.js";
import { updateArtifact } from "../artifacts/update-artifact.js";
Expand Down Expand Up @@ -102,7 +103,9 @@ export async function upgradeContractInPlace(
wasmHash: existing.wasmHash,
network,
skipped: true,
artifactPath: cwd,
// Match the non-skip path (and deploy-contract), which returns the
// artifacts file path — not the working directory.
artifactPath: path.resolve(cwd, "caatinga.artifacts.json"),
};
}

Expand Down