fix: swallow canceled Animation.finished rejections in use_animated_open - #291
Open
ziimakc wants to merge 1 commit into
Open
fix: swallow canceled Animation.finished rejections in use_animated_open#291ziimakc wants to merge 1 commit into
ziimakc wants to merge 1 commit into
Conversation
When the element bound to use_animated_open is removed from the DOM (or its animation/transition is otherwise canceled) before finishing naturally, each canceled animation's `finished` promise rejects with a DOMException (AbortError), which surfaces as an unhandled promise rejection since Promise.all(...).then(...) has no catch handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_animated_openwaits for in-flight animations/transitions on the closing element to finish viaPromise.all(element.getAnimations().map(a => a.finished)).then(...)..finishedpromise rejects with aDOMException(AbortError: The user aborted a request.).Promise.all(...)chain has no.catch(), this becomes an unhandled promise rejection, logged in the browser console asUncaught (in promise) AbortError: The user aborted a request.DropdownMenu) whose content has a plain CSStransition(not even a keyframeanimation— CSS Transitions are also returned byElement.getAnimations()), when the item'son_selecthandler triggers a DOM change (e.g. navigation) that removes the element while its close transition is still running.Fix
Swallow the per-animation rejection with
.catch(() => {})beforePromise.allso a canceled animation resolves like a finished one instead of rejecting the aggregate promise.Reported in #290, with a CDP-verified repro pinpointing the exact
animation.finishedaccess as the throw site.Test plan
cargo fmt --check -p dioxus-primitivesRuntime.exceptionThrown) that the previously-reproducing "avatar dropdown → navigate" flow no longer throws after this change (built against this commit locally).Devin Review