Skip to content

chore: pin soroban-sdk to exact version#590

Merged
1nonlypiece merged 2 commits into
Disciplr-Org:mainfrom
AugistineCreates:chore/pin-soroban-sdk-version
Jun 2, 2026
Merged

chore: pin soroban-sdk to exact version#590
1nonlypiece merged 2 commits into
Disciplr-Org:mainfrom
AugistineCreates:chore/pin-soroban-sdk-version

Conversation

@AugistineCreates
Copy link
Copy Markdown

This pr closes #503

This PR pins the core soroban-sdk workspace dependency to an exact minor/patch version to prevent untracked semantic/feature drift between local development, staging environments, and CI.

Key Changes
  1. Workspace Dependency Pinning
    • Modified contracts/Cargo.toml to strictly pin soroban-sdk to =23.0.1 under [workspace.dependencies].
  2. Workspace Cargo.toml Synchronization
    • Updated contracts/accountability_vault/Cargo.toml to utilize { workspace = true } for both soroban-sdk and soroban-sdk dev-dependencies, ensuring complete workspace-wide dependency alignment.
  3. Lockfile Refresh
    • Ran cargo update inside the contracts directory to update contracts/Cargo.lock, resolving and strictly locking the workspace dependencies to exactly 23.0.1.
  4. Upgrade & Dependency Pinning Policy
    • Added a new ## Upgrade & Dependency Pinning Policy section in contracts/README.md containing strict guidelines for future dependency bumps.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 2, 2026

@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@1nonlypiece 1nonlypiece merged commit 5513f9a into Disciplr-Org:main Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin soroban-sdk to a specific 23.x patch version in contracts/Cargo.toml workspace deps

2 participants